Skip to content

Commit 44cc7c5

Browse files
committed
Improve Common PCH
1 parent fee6ed0 commit 44cc7c5

1 file changed

Lines changed: 10 additions & 0 deletions

File tree

‎Common/Core/CMakeLists.txt‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,13 +44,23 @@ if(NOT DEFINED ENV{USE_RECC})
4444
<Framework/AnalysisTask.h>
4545
<Framework/ConfigContext.h>
4646
<Framework/DataProcessorSpec.h>
47+
# Measured over all 1463 workflow translation units in the tree: these are
48+
# the framework headers a large majority include and that were not
49+
# precompiled here. Percentages are of those 1463.
50+
<Framework/Configurable.h> # 78%
51+
<Framework/InitContext.h> # 78%
52+
<Framework/AnalysisDataModel.h> # 76%
53+
<Framework/HistogramRegistry.h> # 70%
54+
<Framework/AnalysisHelpers.h> # 69%
55+
<Framework/HistogramSpec.h> # 67%
4756
# NOT runDataProcessing.h. It states the contract itself: "we need to
4857
# declare the customize method before include this file". Precompiling it
4958
# makes it the first include in every workflow, so a source's customize() is
5059
# never seen, its options are never registered, and the binary aborts at
5160
# --dump-workflow with "missing option: ...". The link succeeds, so this
5261
# surfaces as a runtime failure with no hint that a PCH caused it.
5362

63+
<cstdint> # 51%
5464
<memory>
5565
<string>
5666
<vector>

0 commit comments

Comments
 (0)