From 96887396e98df8b5d94e0be126e33628e0b57efe Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 26 Oct 2026 13:29:24 -0500 Subject: [PATCH 1/3] ci: pin Homebrew/actions/setup-homebrew to main Homebrew renamed the default branch of Homebrew/actions from master to main, so @master no longer resolves and Homebrew Formula Test fails at job setup. --- .github/workflows/deploy-tap.yml | 2 +- .github/workflows/homebrew.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/deploy-tap.yml b/.github/workflows/deploy-tap.yml index e83eb5534d..ffe284e019 100644 --- a/.github/workflows/deploy-tap.yml +++ b/.github/workflows/deploy-tap.yml @@ -71,7 +71,7 @@ jobs: /usr/bin/sed -i '' "s@^ sha256 \".*\"@ sha256 \"${{ steps.meta.outputs.sha256 }}\"@" packaging/homebrew/mfc.rb - name: Setup Homebrew - uses: Homebrew/actions/setup-homebrew@master + uses: Homebrew/actions/setup-homebrew@main - name: Audit/style formula before pushing run: | diff --git a/.github/workflows/homebrew.yml b/.github/workflows/homebrew.yml index df17d218b0..8aa3d430eb 100644 --- a/.github/workflows/homebrew.yml +++ b/.github/workflows/homebrew.yml @@ -26,7 +26,7 @@ jobs: uses: actions/checkout@v5 - name: Set up Homebrew - uses: Homebrew/actions/setup-homebrew@master + uses: Homebrew/actions/setup-homebrew@main - name: Validate formula syntax with brew style run: | From a69ab4c82d407be55b0610f2d43082b2a23c8cbe Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 26 Oct 2026 13:31:19 -0500 Subject: [PATCH 2/3] homebrew: use post_install_steps instead of post_install The new FormulaAudit/InstallSteps cop rejects post_install methods. --- packaging/homebrew/mfc.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packaging/homebrew/mfc.rb b/packaging/homebrew/mfc.rb index 74465a805d..d743aac65b 100644 --- a/packaging/homebrew/mfc.rb +++ b/packaging/homebrew/mfc.rb @@ -279,9 +279,9 @@ def _homebrew_is_buildable(self): bin.write_exec_script libexec/"mfc" end - def post_install + post_install_steps do # Fix executable permissions for libexec wrapper - (libexec/"mfc").chmod 0755 + set_permissions "mfc", "0755", base: :libexec end # Override to skip relocation checks for Python C extensions in venv From cffbdae5fdd3b1bf20e0507caafbd47deca4ade3 Mon Sep 17 00:00:00 2001 From: Spencer Bryngelson Date: Mon, 26 Oct 2026 13:48:42 -0500 Subject: [PATCH 3/3] ci: trust the temporary Homebrew taps before auditing brew now refuses to load formulae from untrusted taps. The audit in homebrew.yml was failing behind || true, and the audit in deploy-tap.yml has no fallback, so the next formula push to master would fail. --- .github/workflows/deploy-tap.yml | 1 + .github/workflows/homebrew.yml | 2 ++ 2 files changed, 3 insertions(+) diff --git a/.github/workflows/deploy-tap.yml b/.github/workflows/deploy-tap.yml index ffe284e019..9fbfd2e4c2 100644 --- a/.github/workflows/deploy-tap.yml +++ b/.github/workflows/deploy-tap.yml @@ -78,6 +78,7 @@ jobs: brew style packaging/homebrew/mfc.rb # Create temporary tap to audit the formula brew tap-new mfc/local + brew trust mfc/local cp packaging/homebrew/mfc.rb "$(brew --repository)/Library/Taps/mfc/homebrew-local/Formula/mfc.rb" brew audit --online --strict --new --except=homepage mfc/local/mfc || brew audit --online mfc/local/mfc brew untap mfc/local diff --git a/.github/workflows/homebrew.yml b/.github/workflows/homebrew.yml index 8aa3d430eb..e6e91a4c18 100644 --- a/.github/workflows/homebrew.yml +++ b/.github/workflows/homebrew.yml @@ -41,6 +41,7 @@ jobs: echo "Creating temporary local tap..." brew tap-new mflowcode/test + brew trust mflowcode/test cp packaging/homebrew/mfc.rb $(brew --repository)/Library/Taps/mflowcode/homebrew-test/Formula/mfc.rb echo "Running brew audit (online checks)..." @@ -143,6 +144,7 @@ jobs: run: | echo "Creating temporary local tap..." brew tap-new mflowcode/test + brew trust mflowcode/test echo "Copying formula to tap..." cp packaging/homebrew/mfc.rb $(brew --repository)/Library/Taps/mflowcode/homebrew-test/Formula/mfc.rb