From 94ef809bbef0fa6c2f39020c20dc37abcd9a3736 Mon Sep 17 00:00:00 2001 From: Thomas Baumann <39156931+brownbaerchen@users.noreply.github.com> Date: Fri, 23 Oct 2026 11:56:22 +0200 Subject: [PATCH 1/2] Add example for Orion dataset with required fix --- speedup_studies/compute_speedup.py | 20 ++++++++++++++++++++ src/dendro/distributed_dendrogram_v3.py | 2 +- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/speedup_studies/compute_speedup.py b/speedup_studies/compute_speedup.py index 465b1b7..0ea2824 100644 --- a/speedup_studies/compute_speedup.py +++ b/speedup_studies/compute_speedup.py @@ -97,6 +97,26 @@ def getrms(cube, fr1=10, fr2=10): "min_delta": min_delta, "min_npix": min_npix, } + elif args["example"] == "orion": + # Open the cube + path = f"{__file__[: __file__.index(os.path.basename(__file__))]}../data/orion_12CO.fits" + hdu = fits.open(path)[0] + data = hdu.data + hd = hdu.header + + # Survey designs + sigma = 0.3 # K, noise level + ppb = 1.3 # pixels/beam + + data = np.array(data, dtype=float) + + return { + "data": data, + "min_npix": 3 * ppb, + "min_delta": 2 * sigma, + "min_value": sigma, + } + else: raise NotImplementedError diff --git a/src/dendro/distributed_dendrogram_v3.py b/src/dendro/distributed_dendrogram_v3.py index aa41259..1cbf5ac 100644 --- a/src/dendro/distributed_dendrogram_v3.py +++ b/src/dendro/distributed_dendrogram_v3.py @@ -292,7 +292,7 @@ def split_structure(self, structure, split_at): if not isinstance(structure._indices, np.ndarray): structure._indices = np.array(structure._indices) - top_mask = structure._values > split_at + top_mask = structure._values >= split_at bottom_part = Structure( indices=structure._indices[~top_mask], From 11fc44f23bd481c57627a6178d515b71b0ba5843 Mon Sep 17 00:00:00 2001 From: Thomas Baumann Date: Fri, 23 Oct 2026 12:04:54 +0200 Subject: [PATCH 2/2] Add timing data for orion example on JUSUF --- speedup_studies/timing_data/orion.json | 12 ++++++++++++ 1 file changed, 12 insertions(+) create mode 100644 speedup_studies/timing_data/orion.json diff --git a/speedup_studies/timing_data/orion.json b/speedup_studies/timing_data/orion.json new file mode 100644 index 0000000..511506b --- /dev/null +++ b/speedup_studies/timing_data/orion.json @@ -0,0 +1,12 @@ +{ + "v3": { + "1": 13.861861704994226, + "2": 13.693961618002504, + "4": 11.044378619990312, + "8": 23.26084513301612, + "16": 22.725151990016457 + }, + "astrodendro": { + "1": 9.042727890977403 + } +}