From c3c345833d078f7496c0d2bae4f9706df05650c5 Mon Sep 17 00:00:00 2001 From: Eric Voskuil Date: Wed, 28 Oct 2026 03:46:09 -0400 Subject: [PATCH 1/4] Regenerate artifacts. --- .github/workflows/api.yml | 27 +++++++++++++++++++++++++++ builds/cmake/CMakeLists.txt | 11 +++-------- 2 files changed, 30 insertions(+), 8 deletions(-) create mode 100644 .github/workflows/api.yml diff --git a/.github/workflows/api.yml b/.github/workflows/api.yml new file mode 100644 index 00000000..3107d28b --- /dev/null +++ b/.github/workflows/api.yml @@ -0,0 +1,27 @@ +############################################################################### +# Copyright (c) 2014-2026 libbitcoin-node developers (see COPYING). +# +# GENERATED SOURCE CODE, DO NOT EDIT EXCEPT EXPERIMENTALLY +# +############################################################################### + +name: Notify API + +on: + push: + branches: [master] + +permissions: {} + +jobs: + notify-api: + if: github.repository_owner == 'libbitcoin' + runs-on: ubuntu-latest + + steps: + - name: Dispatch to libbitcoin/api + env: + GH_TOKEN: ${{ secrets.API_DISPATCH_TOKEN }} + run: | + gh api repos/libbitcoin/api/dispatches -f event_type=library-push -f "client_payload[repository]=${{ github.repository }}" -f "client_payload[sha]=${{ github.sha }}" + diff --git a/builds/cmake/CMakeLists.txt b/builds/cmake/CMakeLists.txt index 63b1fe9b..0fb4fa03 100644 --- a/builds/cmake/CMakeLists.txt +++ b/builds/cmake/CMakeLists.txt @@ -76,10 +76,6 @@ if ( MSVC ) set( CMAKE_SHARED_LIBRARY_PREFIX "lib" ) endif() -include(CheckCCompilerFlag) -include(CheckCXXCompilerFlag) -include(CheckCXXSourceCompiles) - #------------------------------------------------------------------------------ # Project options. #------------------------------------------------------------------------------ @@ -106,13 +102,12 @@ set( libbitcoin_network_VERSION ${libbitcoin-network_VERSION} ) find_package( Boost 1.86.0 REQUIRED ) -#------------------------------------------------------------------------------ -# Architecture options. -#------------------------------------------------------------------------------ - #------------------------------------------------------------------------------ # Compiler options. #------------------------------------------------------------------------------ +include(CheckCCompilerFlag) +include(CheckCXXCompilerFlag) +include(CheckCXXSourceCompiles) check_cxx_compiler_flag( "-Wall" HAS_FLAG_WALL ) if ( !HAS_FLAG_WALL ) From ceb434e977edec8242bb71e4df86305f8f6880d3 Mon Sep 17 00:00:00 2001 From: Eric Voskuil Date: Wed, 28 Oct 2026 11:58:52 -0400 Subject: [PATCH 2/4] Regenerate artifacts for removed dependency console builds. --- builds/cmake/install-cmake.sh | 6 ++---- builds/cmake/install-presets.sh | 6 ++---- builds/gnu/install-gnu.sh | 2 -- builds/msvc/build-msvc.cmd | 2 -- 4 files changed, 4 insertions(+), 12 deletions(-) diff --git a/builds/cmake/install-cmake.sh b/builds/cmake/install-cmake.sh index cc702a91..108fcd58 100755 --- a/builds/cmake/install-cmake.sh +++ b/builds/cmake/install-cmake.sh @@ -493,14 +493,12 @@ main() libbitcoin_system_FLAGS=() libbitcoin_system_OPTIONS=( - "-Dwith-tests:BOOL=OFF" - "-Dwith-examples:BOOL=OFF") + "-Dwith-tests:BOOL=OFF") libbitcoin_database_FLAGS=() libbitcoin_database_OPTIONS=( - "-Dwith-tests:BOOL=OFF" - "-Dwith-tools:BOOL=OFF") + "-Dwith-tests:BOOL=OFF") libbitcoin_network_FLAGS=() diff --git a/builds/cmake/install-presets.sh b/builds/cmake/install-presets.sh index dbe8ac51..ddc80b12 100755 --- a/builds/cmake/install-presets.sh +++ b/builds/cmake/install-presets.sh @@ -509,14 +509,12 @@ main() libbitcoin_system_FLAGS=() libbitcoin_system_OPTIONS=( - "-Dwith-tests:BOOL=OFF" - "-Dwith-examples:BOOL=OFF") + "-Dwith-tests:BOOL=OFF") libbitcoin_database_FLAGS=() libbitcoin_database_OPTIONS=( - "-Dwith-tests:BOOL=OFF" - "-Dwith-tools:BOOL=OFF") + "-Dwith-tests:BOOL=OFF") libbitcoin_network_FLAGS=() diff --git a/builds/gnu/install-gnu.sh b/builds/gnu/install-gnu.sh index 8f9a4837..67ef8f0a 100755 --- a/builds/gnu/install-gnu.sh +++ b/builds/gnu/install-gnu.sh @@ -525,7 +525,6 @@ main() libbitcoin_system_OPTIONS=( "--without-tests" - "--without-examples" "${with_boost}" "${with_pkgconfigdir}") @@ -533,7 +532,6 @@ main() libbitcoin_database_OPTIONS=( "--without-tests" - "--without-tools" "${with_boost}" "${with_pkgconfigdir}") diff --git a/builds/msvc/build-msvc.cmd b/builds/msvc/build-msvc.cmd index e3587681..3a8f4e3a 100644 --- a/builds/msvc/build-msvc.cmd +++ b/builds/msvc/build-msvc.cmd @@ -163,10 +163,8 @@ if "!libbitcoin_node_TAG!" == "" ( ) set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-system_PARAMS!" - set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-system-examples_PARAMS!" set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-system-test_PARAMS!" set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-database_PARAMS!" - set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-database-tools_PARAMS!" set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-database-test_PARAMS!" set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-network_PARAMS!" set "REMAPPED_PARAMS=!REMAPPED_PARAMS! !libbitcoin-network-test_PARAMS!" From 1ac324a85eea958ff038f63642809ea7e7127f4d Mon Sep 17 00:00:00 2001 From: Eric Voskuil Date: Wed, 28 Oct 2026 17:11:45 -0400 Subject: [PATCH 3/4] Remove api workflow. --- .github/workflows/api.yml | 27 --------------------------- 1 file changed, 27 deletions(-) delete mode 100644 .github/workflows/api.yml diff --git a/.github/workflows/api.yml b/.github/workflows/api.yml deleted file mode 100644 index 3107d28b..00000000 --- a/.github/workflows/api.yml +++ /dev/null @@ -1,27 +0,0 @@ -############################################################################### -# Copyright (c) 2014-2026 libbitcoin-node developers (see COPYING). -# -# GENERATED SOURCE CODE, DO NOT EDIT EXCEPT EXPERIMENTALLY -# -############################################################################### - -name: Notify API - -on: - push: - branches: [master] - -permissions: {} - -jobs: - notify-api: - if: github.repository_owner == 'libbitcoin' - runs-on: ubuntu-latest - - steps: - - name: Dispatch to libbitcoin/api - env: - GH_TOKEN: ${{ secrets.API_DISPATCH_TOKEN }} - run: | - gh api repos/libbitcoin/api/dispatches -f event_type=library-push -f "client_payload[repository]=${{ github.repository }}" -f "client_payload[sha]=${{ github.sha }}" - From a77718067049127d29cf8d189317be196e66840c Mon Sep 17 00:00:00 2001 From: Eric Voskuil Date: Wed, 28 Oct 2026 19:02:04 -0400 Subject: [PATCH 4/4] Move include dependency table to define.cpp. --- include/bitcoin/node/define.hpp | 25 ------------------ src/define.cpp | 46 +++++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+), 25 deletions(-) create mode 100644 src/define.cpp diff --git a/include/bitcoin/node/define.hpp b/include/bitcoin/node/define.hpp index 7402895a..4fdc3127 100644 --- a/include/bitcoin/node/define.hpp +++ b/include/bitcoin/node/define.hpp @@ -76,28 +76,3 @@ using type_id = network::messages::peer::inventory_item::type_id; } // namespace libbitcoin #endif - -// define.hpp is the common include for /node. -// All non-node headers include define.hpp. -// Node inclusions are chained as follows. - -// version : -// error : version -// events : error -// chase : events -// define : chase - -// Other directory common includes are not internally chained. -// Each header includes only its required common headers. - -// estimator : define -// settings : define -// configuration : define settings -// parser : define configuration -// /chasers : define configuration estimator [forward: full_node] -// /channels : define configuration -// full_node : define estimator /chasers -// session : define estimator [forward: full_node] -// /messages : define -// /protocols : define estimator /channels [session.hpp] -// /sessions : define /protocols [forward: full_node] \ No newline at end of file diff --git a/src/define.cpp b/src/define.cpp new file mode 100644 index 00000000..329eac31 --- /dev/null +++ b/src/define.cpp @@ -0,0 +1,46 @@ +/** + * Copyright (c) 2011-2026 libbitcoin developers + * + * This file is part of libbitcoin. + * + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU Affero General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see . + */ +#include + +// define.hpp is the common include for /node. +// All non-node headers include define.hpp. +// Node inclusions are chained as follows. + +// version : +// error : version +// events : error +// chase : events +// define : chase + +// Other directory common includes are not internally chained. +// Each header includes only its required common headers. + +// block_arena : define +// block_memory : block_arena +// settings : define +// configuration : settings +// estimator : define +// /chasers : configuration estimator [forward: full_node] +// /channels : configuration +// /protocols : /channels /chasers [sessions/session.hpp] +// /sessions : /protocols [forward: full_node] +// full_node : /sessions + +// When a symbol is unexplainably undefined, its defining include is probably +// creating the circularity.