From 364f5228850e1587ac6b8c49ed595e24dc0f20cf Mon Sep 17 00:00:00 2001 From: Christophe Dervieux Date: Mon, 19 Oct 2026 15:32:11 +0200 Subject: [PATCH] Cover every social meta tag in the og:site_name tests The website meta markdown pipeline rewrites the content of five tags after rendering: og:title, twitter:title, og:site_name, og:description and twitter:description. Each rewrite must touch only the tag Quarto wrote, never a same-named tag the page added itself. The opt-out fixture had decoys for only three of the names, so a regression in the description handler would have gone unnoticed. It now has a decoy for each of the five, and about.qmd asserts that Quarto's own description and twitter:title tags still get their rendered values next to the decoys. The existing fixtures all use plain-string site names, where the value written into og:site_name already equals the rendered text. Dropping the og:site_name rewrite from the site title handler left them all passing. markdown-site-name.qmd uses a site-name with Markdown and a shortcode, so the tag only gets the expected plain text if the rendered value is written back. --- .../docs/smoke-all/2026/10/19/issue-14917/about.qmd | 2 ++ .../2026/10/19/issue-14917/markdown-site-name.qmd | 12 ++++++++++++ .../smoke-all/2026/10/19/issue-14917/opt-out.qmd | 4 ++++ 3 files changed, 18 insertions(+) create mode 100644 tests/docs/smoke-all/2026/10/19/issue-14917/markdown-site-name.qmd diff --git a/tests/docs/smoke-all/2026/10/19/issue-14917/about.qmd b/tests/docs/smoke-all/2026/10/19/issue-14917/about.qmd index aa3ac0d7d7..921034b96e 100644 --- a/tests/docs/smoke-all/2026/10/19/issue-14917/about.qmd +++ b/tests/docs/smoke-all/2026/10/19/issue-14917/about.qmd @@ -23,6 +23,8 @@ _quarto: - 'meta[name="twitter:title"][content="DECOY TITLE"]' - 'meta[name="twitter:description"][content="DECOY DESCRIPTION"]' - 'meta[property="og:title"][content^="About"]' + - 'meta[property="og:description"][content="About page description"]' + - 'meta[name="twitter:title"][content^="About"]' - 'meta[name="twitter:description"][content="About page description"]' - ['meta[property="og:site_name"][content="SITE TITLE"]'] --- diff --git a/tests/docs/smoke-all/2026/10/19/issue-14917/markdown-site-name.qmd b/tests/docs/smoke-all/2026/10/19/issue-14917/markdown-site-name.qmd new file mode 100644 index 0000000000..452a10e8c0 --- /dev/null +++ b/tests/docs/smoke-all/2026/10/19/issue-14917/markdown-site-name.qmd @@ -0,0 +1,12 @@ +--- +title: "Summary" +open-graph: + site-name: "**Bold** {{< meta title >}} name" +_quarto: + tests: + html: + ensureHtmlElements: + - ['meta[property="og:site_name"][content="Bold Summary name"]'] +--- + +An explicit `open-graph.site-name` containing Markdown and a shortcode must reach `og:site_name` as rendered plain text. diff --git a/tests/docs/smoke-all/2026/10/19/issue-14917/opt-out.qmd b/tests/docs/smoke-all/2026/10/19/issue-14917/opt-out.qmd index fb9d40d325..3bebdc4a25 100644 --- a/tests/docs/smoke-all/2026/10/19/issue-14917/opt-out.qmd +++ b/tests/docs/smoke-all/2026/10/19/issue-14917/opt-out.qmd @@ -9,6 +9,8 @@ format: + + _quarto: tests: html: @@ -16,6 +18,8 @@ _quarto: - - 'meta[property="og:site_name"][content="PAGE SITE NAME"]' - 'meta[property="og:title"][content="PAGE TITLE"]' - 'meta[name="twitter:title"][content="PAGE TITLE"]' + - 'meta[property="og:description"][content="PAGE DESCRIPTION"]' + - 'meta[name="twitter:description"][content="PAGE DESCRIPTION"]' - ['meta[property="og:site_name"][content="SITE TITLE"]'] ---