From 2da47b99f86ac290d9348ee7dfe72235eec4a53a Mon Sep 17 00:00:00 2001 From: Waleed Date: Sun, 1 Nov 2026 19:12:53 -0800 Subject: [PATCH 01/12] improvement(ci): check lint and types before pushing (#9555) --- .github/CI.md | 2 ++ .husky/pre-push | 5 +++++ 2 files changed, 7 insertions(+) create mode 100755 .husky/pre-push diff --git a/.github/CI.md b/.github/CI.md index 271311ede03..4ae2455bf60 100644 --- a/.github/CI.md +++ b/.github/CI.md @@ -48,3 +48,5 @@ The separate `desktop-e2e` workflow retains its desktop-specific path filters. I The initial weights are median test durations in seconds from runs [39734295953](https://github.com/simstudioai/sim/actions/runs/39734295953), [39833640524](https://github.com/simstudioai/sim/actions/runs/39833640524), and [39836596108](https://github.com/simstudioai/sim/actions/runs/39836596108). Refresh them from complete `desktop-smoke-reports-*` artifacts when the workload changes: sum `tests[].results[].duration` by `spec.file` in each run, take the median across runs, and divide milliseconds by 1,000. The weights steer scheduling only; Playwright discovery owns coverage. Before adopting new weights, compare repeated paired runs and the complete case/status multiset, including skipped cases and retries. Each shard uploads its coverage/timing report, the complete discovery report, and its deterministic shard plan. `bun run test:scripts scripts/duration-shards.test.ts scripts/desktop-e2e.test.ts` checks partition coverage, unknown files, deterministic ordering, and balancing. The CLI regression executes tiny browser-free Playwright fixtures to prove that imported test factories and paths containing regex characters are selected correctly; it launches no Electron or browser. + +Local pushes run `lint:check` and `type-check` through Husky before Git sends commits. These gates reuse Turborepo's task cache; a failure stops the push. The pre-commit hook still formats staged files, and hosted CI owns tests, audits, builds, and acceptance checks. diff --git a/.husky/pre-push b/.husky/pre-push new file mode 100755 index 00000000000..dd0fdf09e2d --- /dev/null +++ b/.husky/pre-push @@ -0,0 +1,5 @@ +#!/bin/sh +set -e + +bun run lint:check +bun run type-check From 974dd6cd3e6847310bdc23cf8a10f51c2c233fd1 Mon Sep 17 00:00:00 2001 From: Waleed Date: Sun, 1 Nov 2026 19:52:49 -0800 Subject: [PATCH 02/12] improvement(ci): shorten the acceptance critical path (#9556) * improvement(ci): refresh integration shard duration weights * improvement(ci): parallelize acceptance suites and avoid slow dependency restores * improvement(ci): advance extension access polling in acceptance tests * chore(ci): document acceptance timing and shard refresh * fix(ci): settle extension screenshots after advancing browser timers * fix(ci): finish finite animations in clock-controlled extension checks * fix(ci): preserve access revalidation budgets with virtual timers --- .github/CI.md | 10 +- .github/actions/setup/action.yml | 21 +- .github/ci-suites.json | 8 + .github/scripts/http-e2e.sh | 87 ++-- .github/workflows/checks.yml | 2 +- .../sim/scripts/test-browser-extension-e2e.ts | 296 ++++++----- scripts/ci-changes.test.ts | 26 +- vitest.integration-durations.json | 486 +++++++++--------- 8 files changed, 544 insertions(+), 392 deletions(-) diff --git a/.github/CI.md b/.github/CI.md index 4ae2455bf60..9fbeb94e472 100644 --- a/.github/CI.md +++ b/.github/CI.md @@ -24,12 +24,20 @@ SEO depends on workspace UI and server code: landing pages reuse workspace prici Affected type-checks follow the package graph too; repository audits and lint run whenever the checks workflow runs. Workspace-only unit jobs use a free GitHub runner and do not start the app test shards. -Database integration and lightweight HTTP suites run on free standard GitHub runners with matching GitHub cache setup. A same-source integration comparison of 16 jobs per provider (32 total) had a slowest shard of 6m 04s on 2-vCPU Blacksmith versus 6m 55s on free GitHub, with identical coverage. GitHub trades the observed 51 seconds for zero runner compute cost. This is one paired sample, not a long-run percentile estimate. These explicitly selected GitHub jobs do not follow `CI_PROVIDER`. +Database integration and lightweight HTTP suites run on free standard GitHub runners with provider-specific dependency setup. A same-source integration comparison of 16 jobs per provider (32 total) had a slowest shard of 6m 04s on 2-vCPU Blacksmith versus 6m 55s on free GitHub, with identical coverage. GitHub trades the observed 51 seconds for zero runner compute cost. This is one paired sample, not a long-run percentile estimate. These explicitly selected GitHub jobs do not follow `CI_PROVIDER`. + +GitHub runners install dependencies directly rather than transferring Bun and `node_modules` archives. In a same-source paired comparison, those restores took 26.2 seconds before an 82-millisecond install, while a clean install took 12.42 seconds. This is one paired observation; retain the policy only while repeated CI timings support it. Blacksmith keeps its sticky dependency disks. GitHub Turbo output caches remain enabled for jobs that request them, with a commit-specific key and a task/event/fork-scoped restore prefix, so a rerun can reuse an exact entry without creating another archive. Push jobs never restore pull-request entries. Memory-heavy builds and browser jobs retain appropriately sized Blacksmith runners. Electron uses 4-vCPU Blacksmith: both shards passed within 14 seconds of the 8-vCPU control; the free GitHub rest shard was slower and its lease run stalled. Every HTTP and browser group consumes the same production build in an isolated job/database. Electron also uses that build and skips its development-route warm-up. Local HTTP and Electron development runs retain their dev-server behavior. Build inputs exclude test-only files so a harness edit can reuse an unchanged production build. +Desktop inbox protocol, assistant actions UI, and organization search UI run as three parallel HTTP jobs with isolated databases, apps, and reports. They retain one acceptance task boundary, so changing any of their harnesses selects all three jobs. Desktop inbox needs no browser. The UI jobs and browser extension install Chromium while their app starts, waiting for both before executing assertions; browser-install failures still fail the job and preserve the install log. No acceptance assertions are removed by the split. + +Browser extension acceptance keeps native streaming and first-open capture checks on real timers. Its access-revalidation scenarios then reopen the persistent browser profile and install Playwright's clock before the app mounts. Advancing the production polling timers preserves real HTTP and database authorization checks without waiting through each polling interval. Capture timestamps originate in Chromium's isolated world, so the harness restores wall time after each advance. Live-provider runs retain native timing throughout. + +Integration shard weights come from successful reports for both push and migration provisioning paths. Refresh them with `scripts/update-integration-durations.ts`, then check the new partition against a separate complete run before adopting it. Weights only change scheduling; discovery still owns coverage. The current refresh uses runs [41348786822](https://github.com/simstudioai/sim/actions/runs/41348786822) and [41377145857](https://github.com/simstudioai/sim/actions/runs/41377145857), with [41377810718](https://github.com/simstudioai/sim/actions/runs/41377810718) held out for validation. + SCIM's production app uses a `sim.ai` fixture hostname mapped to loopback, since `NEXT_PUBLIC_FORCE_HOSTED` is ignored in production. Readiness, HTTP tests, and internal API requests still connect to loopback. The SCIM suite verifies that ending an Enterprise subscription rejects both owner administration and an existing bearer token, and that restoring it restores access. ## Coverage removed or consolidated diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml index 575623a6fb9..16babab1c9a 100644 --- a/.github/actions/setup/action.yml +++ b/.github/actions/setup/action.yml @@ -1,5 +1,5 @@ name: setup -description: Install the pinned Bun and Node toolchain, mount the dependency (and optionally Turbo) caches, and install workspace dependencies. +description: Install the pinned toolchain and workspace dependencies, using sticky dependency disks on Blacksmith and optional Turbo output caching on either provider. inputs: provider: @@ -19,12 +19,13 @@ inputs: required: false default: '' -# Cache keys are scoped by event name, and fork PRs get their own namespace on +# Sticky disk keys are scoped by event name, and fork PRs get their own namespace on # top: untrusted fork runs must never share a cache with push runs (whose caches # feed production image builds) or with trusted internal-PR runs. # -# node_modules also keys on the lockfile hash: a sticky disk is a mutable volume, -# and `bun install --frozen-lockfile` adds what the lockfile needs without +# GitHub runners install directly: restoring both dependency archives takes longer +# than a clean Bun install. node_modules on sticky disks keys on the lockfile hash: +# `bun install --frozen-lockfile` adds what the lockfile needs without # pruning what it dropped, so branches on different lockfiles were contaminating # each other (a stale @next/swc 16.2.6 outlived the 16.2.11 bump). The bun and # Turbo caches are content/hash-addressed, so they stay shared — that is what @@ -45,6 +46,7 @@ runs: registry-url: ${{ inputs.registry-url }} - name: Mount Bun cache + if: inputs.provider == '' || inputs.provider == 'blacksmith' uses: ./.github/actions/cache with: provider: ${{ inputs.provider }} @@ -52,6 +54,7 @@ runs: path: ~/.bun/install/cache - name: Mount node_modules + if: inputs.provider == '' || inputs.provider == 'blacksmith' uses: ./.github/actions/cache with: provider: ${{ inputs.provider }} @@ -59,13 +62,21 @@ runs: path: ./node_modules - name: Mount Turbo cache - if: inputs.turbo-cache-key != '' + if: inputs.turbo-cache-key != '' && (inputs.provider == '' || inputs.provider == 'blacksmith') uses: ./.github/actions/cache with: provider: ${{ inputs.provider }} key: ${{ github.repository }}-${{ inputs.turbo-cache-key }}-${{ github.event_name }}${{ github.event.pull_request.head.repo.fork && '-fork' || '' }} path: ./.turbo + - name: Restore and save Turbo cache + if: inputs.turbo-cache-key != '' && inputs.provider != '' && inputs.provider != 'blacksmith' + uses: actions/cache@55cc8345863c7cc4c66a329aec7e433d2d1c52a9 # v5 + with: + key: ${{ github.repository }}-${{ inputs.turbo-cache-key }}-${{ github.event_name }}${{ github.event.pull_request.head.repo.fork && '-fork' || '' }}-${{ github.sha }} + restore-keys: ${{ github.repository }}-${{ inputs.turbo-cache-key }}-${{ github.event_name }}${{ github.event.pull_request.head.repo.fork && '-fork' || '' }}- + path: ./.turbo + # Bun retries a failed request itself, but a registry connection that stalls # without failing leaves `bun install` waiting until the job's own timeout # cancels it, the whole budget spent on one hung step. Healthy installs finish diff --git a/.github/ci-suites.json b/.github/ci-suites.json index a9bc643c275..c8ad7304328 100644 --- a/.github/ci-suites.json +++ b/.github/ci-suites.json @@ -16,6 +16,14 @@ "group": "desktop-inbox", "task": "ci:e2e-desktop-inbox" }, + { + "group": "assistant-actions", + "task": "ci:e2e-desktop-inbox" + }, + { + "group": "organization-search", + "task": "ci:e2e-desktop-inbox" + }, { "group": "browser-extension", "task": "ci:e2e-browser-extension" diff --git a/.github/scripts/http-e2e.sh b/.github/scripts/http-e2e.sh index 3443959ef4d..dce1ca6d394 100755 --- a/.github/scripts/http-e2e.sh +++ b/.github/scripts/http-e2e.sh @@ -3,7 +3,7 @@ # CI groups, which reuse the production build from `e2e-build`. # The job extracts it into apps/sim/.next before running these suites. # -# Usage: http-e2e.sh (run from apps/sim) +# Usage: http-e2e.sh (run from apps/sim) # # The job provides DATABASE_URL, BETTER_AUTH_SECRET and ENCRYPTION_KEY; each group sets the rest of # its app's environment here. Reports and server logs land in $RUNNER_TEMP/e2e. @@ -20,7 +20,7 @@ # telemetry flush runs detached and still writes .next/dev). set -euo pipefail -group=${1:?usage: http-e2e.sh } +group=${1:?usage: http-e2e.sh } report_dir="$RUNNER_TEMP/e2e" ready_timeout_seconds=600 mkdir -p "$report_dir" @@ -71,6 +71,24 @@ finish() { } trap finish EXIT +start_browser_install() { + local name=$1 + shift + browsers_log="$report_dir/$name-playwright-install.log" + setsid --wait bunx --no-install playwright install --with-deps "$@" > "$browsers_log" 2>&1 & + browsers_pid=$! +} + +wait_for_browsers() { + if ! wait "$browsers_pid"; then + browsers_pid='' + tail -n 100 "$browsers_log" + echo "::error::Playwright browser install failed." + exit 1 + fi + browsers_pid='' +} + # start_app