From 5ba882ce11f1baeedb794fab4f306ab7c8a7a964 Mon Sep 17 00:00:00 2001
From: Philip Z <hello@teaql.io>
Date: Tue, 20 Oct 2026 11:51:42 +0800
Subject: [PATCH] test(jdbc): cover confirmed rollback retry before close

---
 .../sqlite/JdbcRollbackCloseSqliteTest.java   | 72 +++++++++++++++++++
 1 file changed, 72 insertions(+)

diff --git a/teaql-sqlite/src/test/java/io/teaql/sqlite/JdbcRollbackCloseSqliteTest.java b/teaql-sqlite/src/test/java/io/teaql/sqlite/JdbcRollbackCloseSqliteTest.java
index f9cd6b9b..315fc085 100644
--- a/teaql-sqlite/src/test/java/io/teaql/sqlite/JdbcRollbackCloseSqliteTest.java
+++ b/teaql-sqlite/src/test/java/io/teaql/sqlite/JdbcRollbackCloseSqliteTest.java
@@ -9,6 +9,7 @@
 import java.sql.Connection;
 import java.sql.SQLException;
 import java.util.concurrent.atomic.AtomicBoolean;
+import java.util.concurrent.atomic.AtomicInteger;
 import java.util.concurrent.atomic.AtomicReference;
 import javax.sql.DataSource;
 import org.junit.Test;
@@ -35,6 +36,77 @@ private enum AbortBehavior { CLOSE, THROW, NO_OP }
         verifyFailedRollback(AbortBehavior.NO_OP);
     }
 
+    @Test public void confirmedRollbackRetryAllowsSafeClose() throws Exception {
+        var backing = new SQLiteDataSource();
+        backing.setUrl("jdbc:sqlite:" + Files.createTempFile("teaql-rollback-retry-", ".db"));
+        try (var connection = backing.getConnection(); var statement = connection.createStatement()) {
+            statement.execute("CREATE TABLE rollback_close_probe (id INTEGER PRIMARY KEY)");
+        }
+
+        var rollbackAttempts = new AtomicInteger();
+        var rollbackConfirmed = new AtomicBoolean();
+        var closedAfterRollback = new AtomicBoolean();
+        var committedOnUnsafeClose = new AtomicBoolean();
+        var aborted = new AtomicBoolean();
+        var opened = new AtomicReference<Connection>();
+        DataSource injecting = (DataSource) Proxy.newProxyInstance(
+                DataSource.class.getClassLoader(), new Class<?>[] {DataSource.class},
+                (proxy, method, args) -> {
+                    Object value = invoke(backing, method, args);
+                    if (!method.getName().equals("getConnection")) return value;
+                    Connection actual = (Connection) value;
+                    opened.set(actual);
+                    return Proxy.newProxyInstance(Connection.class.getClassLoader(),
+                            new Class<?>[] {Connection.class}, (connectionProxy, operation, parameters) -> {
+                                if (operation.getName().equals("rollback")) {
+                                    if (rollbackAttempts.incrementAndGet() == 1) {
+                                        throw new SQLException("one-shot injected rollback failure");
+                                    }
+                                    Object result = invoke(actual, operation, parameters);
+                                    rollbackConfirmed.set(true);
+                                    return result;
+                                }
+                                if (operation.getName().equals("close")) {
+                                    if (rollbackConfirmed.get()) {
+                                        closedAfterRollback.set(true);
+                                    } else {
+                                        // Model a pool that commits a still-active transaction on close.
+                                        actual.commit();
+                                        committedOnUnsafeClose.set(true);
+                                    }
+                                }
+                                if (operation.getName().equals("abort")) aborted.set(true);
+                                return invoke(actual, operation, parameters);
+                            });
+                });
+        var executor = new JdbcSqlExecutor(injecting);
+
+        try {
+            assertThrows(TransactionOutcomeUnknownException.class, () ->
+                    executor.executeInTransaction(() -> {
+                        executor.update("INSERT INTO rollback_close_probe (id) VALUES (?)", new Object[] {1L});
+                        throw new IllegalStateException("abort this transaction");
+                    }));
+            assertEquals("rollback must be retried exactly once", 2, rollbackAttempts.get());
+            assertTrue("the retry must confirm rollback", rollbackConfirmed.get());
+            assertTrue("close is safe after confirmed rollback", closedAfterRollback.get());
+            assertFalse("abort is unnecessary after confirmed rollback", aborted.get());
+            assertFalse("close must not commit pending writes", committedOnUnsafeClose.get());
+        } finally {
+            Connection actual = opened.get();
+            if (actual != null && !actual.isClosed()) {
+                actual.rollback();
+                actual.close();
+            }
+        }
+        try (var connection = backing.getConnection();
+             var statement = connection.prepareStatement("SELECT COUNT(*) FROM rollback_close_probe");
+             var rows = statement.executeQuery()) {
+            assertTrue(rows.next());
+            assertEquals(0, rows.getInt(1));
+        }
+    }
+
     private static void verifyFailedRollback(AbortBehavior abortBehavior) throws Exception {
         var backing = new SQLiteDataSource();
         backing.setUrl("jdbc:sqlite:" + Files.createTempFile("teaql-rollback-close-", ".db"));