Repository navigation
Save each framework's own CFDefinitions, matched by identifier (CGE-184) - #50
Merged
Merged
Conversation
The editor built CFDefinitions on save from the tenant-wide catalogue, matching definitions by identifier or by title. When two frameworks had a definition with the same title, saving either one pulled in the other's. Bad data in one framework could then make another framework's saves fail validation. - Match definitions only by URI identifier. Items that name a type or subject by text alone, with no URI, no longer pick up definitions with a matching title. - Keep each framework's own definitions from its CFPackage and put them ahead of the tenant catalogue, for both the save and the pickers. - Carry CFDefinitions-level extensions through on save. The server keeps the stored ones when a save leaves them out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The editor built CFDefinitions on save from the tenant-wide catalogue, matching definitions by identifier or by title. When two frameworks had a definition with the same title, saving either one pulled in the other's. Bad data in one framework could then make another framework's saves fail validation.