Skip to content

Show a framework's own associations in the tree view - #54

Open
stanbilliet wants to merge 1 commit into
1EdTech:mainfrom
stanbilliet:feat/tree-view-inline-associations
Open

stanbilliet wants to merge 1 commit into
1EdTech:mainfrom
stanbilliet:feat/tree-view-inline-associations

Conversation

@stanbilliet

Copy link
Copy Markdown
Contributor
  • The Associated Frameworks panel only read alignment documents, so non-hierarchical associations stored in the framework itself (where CASE 1.1 keeps them) never showed up
  • Associations within the framework appear under "this framework"; associations to items in other frameworks appear under that framework (resolved from loaded frameworks, else via the item's CFDocumentURI)
  • Shown read-only in teal and never written to an alignment document, so they aren't duplicated
  • Skips isChildOf/isPartOf, links to the CFDocument and non-CASE targetTypes
  • New inlineAlignments helper with tests; all editor tests pass
  • Editing these associations from the tree view is left for a follow-up: they would have to be saved with the framework itself rather than as an alignment document (the canvas view, which could edit internal ones, is currently disabled)

…meworks panel

The panel only read alignment documents (frameworkType "Alignment"), so
non-hierarchical associations stored in the framework itself - where CASE 1.1
keeps an association, in the document of its origin - never showed up.

- New domain helper inlineAlignmentsOf: non-hierarchical associations from an
  item of the framework to a CASE item (skips isChildOf/isPartOf, links to the
  CFDocument and non-CASE targetTypes); groupInlineAlignmentsByTarget groups
  them by the framework that holds the destination.
- Destinations in the framework itself form the self target; others are
  resolved from frameworks already in the session, then from the server via
  the item's CFDocumentURI (GET /CFItems/{id}, bounded concurrency).
- Each such framework is added to the target list. Inline associations are
  drawn in teal and listed read-only in the badge popover; they are never
  written to an alignment document, so saving alignments does not duplicate them.
- The badge popover now lists only the associations of the expanded target,
  matching the badge count.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant