Skip to content

fix: prevent crash when opening file:// links from LSP tooltips - #2977

Merged
bajrangCoder merged 1 commit into
mainfrom
fix/open-in-browser-file-uri
Oct 18, 2026
Merged

bajrangCoder merged 1 commit into
mainfrom
fix/open-in-browser-file-uri

Conversation

@bajrangCoder

Copy link
Copy Markdown
Member

Fixes #2967

Open file:// links in LSP hover/signature docs in the editor, and guard
the native openInBrowser against file URIs and launch failures.
@greptile-apps

greptile-apps Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Opens file: links from LSP hover and signature documentation inside the editor.

  • File links in LSP tooltips open at their referenced editor location.
  • Android keeps empty and file URLs out of the external browser.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Click documentation link] --> B{file URL?}
  B -->|Yes| C[Stop browser navigation]
  C --> D[Read line and column]
  D --> E[Open file in editor]
  B -->|No| F[Existing browser handler]
  F --> G[Android browser helper]
  G --> H[Report success or error]
Loading

Reviews (1) · Last reviewed commit: "fix: prevent crash when opening file:// ..." · Reviewed by Greptile

@bajrangCoder
bajrangCoder added this pull request to the merge queue Oct 18, 2026
Merged via the queue into main with commit d755c31 Oct 18, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in The Code Board - Acode Oct 18, 2026
@bajrangCoder
bajrangCoder deleted the fix/open-in-browser-file-uri branch October 18, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Acode Crash Report

1 participant