Repository navigation
Add Python syntax check to smoke test - #379
Merged
Merged
Conversation
briantoby
commented
Nov 2, 2026
briantoby
left a comment
briantoby
left a comment
Collaborator
Author
There was a problem hiding this comment.
This looks like what I want. Needs a test
Collaborator
Author
|
This is not doing exactly what I want in that it appears to be using an older Python for every compileall step. Though I could live with this if there is no better choice. This should fail for Python 3.10 and 3.11 but not 3.12+. |
Collaborator
Author
|
Looks good. Committing even though all Mac tests have not run. Will get retested after merge anyway. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
compileallstep overGSASIIto the smoke-test workflow. This checks every Python module for syntax errors under each Python version in the matrix, including the Python 3.10/3.11-incompatible f-string syntax that the existing test imports did not exercise.