Repository navigation
AFIT-80 - Implementation of configurable parameters for FV0 reconstruction - #15881
Merged
Merged
Conversation
… parameters in BaseRecoTask
Co-authored-by: Felix Schlepper <f3sch.git@outlook.com>
wpierozak
requested review from
afurs,
andreasmolander,
jotwinow and
sahilupadhyaya92
as code owners
October 1, 2026 09:47
Please consider the following formatting changes to AliceO2Group#15881
sahilupadhyaya92
approved these changes
Oct 7, 2026
Contributor
Author
|
@shahor02 One check is failing for reason unrelated to this PR for few days, is it possible to skip it? |
maciacco
pushed a commit
to maciacco/AliceO2
that referenced
this pull request
Oct 26, 2026
…uction (AliceO2Group#15881) * created fv0::TimeFilter and fv0::ChargeFilter classes for reco configuration * replaced Digit configuration opitons with ChargeFilter and TimeFilter parameters in BaseRecoTask * prefixed FV0 reco configuration structure with 'FV0Reco' * Merged Charge and Time fileters to one Fv0RecoConfig * Renamed files * Fixed typo in FV0 CMakeLists * Update DataFormats/Detectors/FIT/FV0/src/DataFormatsFV0LinkDef.h * Added explicit casting to uin8_t in FV0RecoConfig to remove compilation warning * Added ClassDefNV statement to FV0RecoConfig struct * Fixed typos and #define directives, removed unused includes Co-authored-by: Wiktor Pierozak <wpieroza@alifitlab010.dyndns.cern.ch> Co-authored-by: Felix Schlepper <f3sch.git@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved FV0 reconstruction parameters from digitizer configuration structure to dedicated configurable structure and updated reconstruction code to use it.
FV0RecoConfig inherits from ConfigurableParamHelper, so it can be modified by either command-line arguments or object fetched from CCDB.