Skip to content

DPL CCDB fetcher was ignorint condition-timestamp option #16001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shahor02 merged 1 commit into from
Oct 24, 2026
+9 −3
Merged

DPL CCDB fetcher was ignorint condition-timestamp option #16001

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions Framework/CCDBSupport/src/CCDBHelpers.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,7 @@ AlgorithmSpec CCDBHelpers::fetchFromCCDB()
return adaptStateful([](CallbackService& callbacks, ConfigParamRegistry const& options, DeviceSpec const& spec) {
std::shared_ptr<CCDBFetcherHelper> helper = std::make_shared<CCDBFetcherHelper>();
initialiseHelper(*helper, options, spec.outputs);
auto forcedTimestamp = options.get<int64_t>("condition-timestamp");
/// Add a callback on stop which dumps the statistics for the caching per
/// path
callbacks.set<CallbackService::Id::Stop>([helper]() {
Expand All @@ -413,7 +414,7 @@ AlgorithmSpec CCDBHelpers::fetchFromCCDB()
}
});

return adaptStateless([helper](DataTakingContext& dtc, DataAllocator& allocator, TimingInfo& timingInfo, DataProcessingStats& stats) {
return adaptStateless([helper, forcedTimestamp](DataTakingContext& dtc, DataAllocator& allocator, TimingInfo& timingInfo, DataProcessingStats& stats) {
auto sid = _o2_signpost_id_t{(int64_t)timingInfo.timeslice};
O2_SIGNPOST_START(ccdb, sid, "fetchFromCCDB", "Fetching CCDB objects for timeslice %" PRIu64, (uint64_t)timingInfo.timeslice);
static Long64_t orbitResetTime = -1;
Expand All @@ -423,6 +424,7 @@ AlgorithmSpec CCDBHelpers::fetchFromCCDB()
timingInfo.creation = lastTimeUsed;
}
lastTimeUsed = timingInfo.creation;
auto lookupTimestamp = forcedTimestamp > 0 ? forcedTimestamp : static_cast<int64_t>(timingInfo.creation);
// Fetch the CCDB object for the CTP
{
const std::string path = "CTP/Calib/OrbitReset";
Expand All @@ -445,9 +447,9 @@ AlgorithmSpec CCDBHelpers::fetchFromCCDB()
const auto& api = helper->getAPI(path);
if (checkValidity && (!api.isSnapshotMode() || etag.empty())) { // in the snapshot mode the object needs to be fetched only once
helper->lastCheckedTFCounterOrbReset = counter;
api.loadFileToMemory(v, path, metadata, timingInfo.creation, &headers, etag, helper->createdNotAfter, helper->createdNotBefore);
api.loadFileToMemory(v, path, metadata, lookupTimestamp, &headers, etag, helper->createdNotAfter, helper->createdNotBefore);
if ((headers.count("Error") != 0) || (etag.empty() && v.empty())) {
LOGP(fatal, "Unable to find CCDB object {}/{}", path, timingInfo.creation);
LOGP(fatal, "Unable to find CCDB object {}/{}", path, lookupTimestamp);
// FIXME: I should send a dummy message.
return;
}
Expand Down Expand Up @@ -504,6 +506,9 @@ AlgorithmSpec CCDBHelpers::fetchFromCCDB()
}
timestamp = timingInfo.creation;
}
if (forcedTimestamp > 0) {
timestamp = forcedTimestamp;
}
// Fetch the rest of the objects.
O2_SIGNPOST_EVENT_EMIT(ccdb, sid, "fetchFromCCDB", "Fetching objects. Run %{public}s. OrbitResetTime %lld. Creation %lld. Timestamp %lld. firstTForbit %" PRIu32,
dtc.runNumber.data(), orbitResetTime, timingInfo.creation, timestamp, timingInfo.firstTForbit);
Expand Down
1 change: 1 addition & 0 deletions Framework/Core/src/WorkflowHelpers.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,7 @@ void WorkflowHelpers::injectServiceDevices(WorkflowSpec& workflow, ConfigContext
.name = "internal-dpl-ccdb-backend",
.outputs = {},
.options = {{"condition-backend", VariantType::String, defaultConditionBackend(), {"URL for CCDB"}},
{"condition-timestamp", VariantType::Int64, 0ll, {"Force timestamp for CCDB lookup"}},
{"condition-not-before", VariantType::Int64, 0ll, {"do not fetch from CCDB objects created before provide timestamp"}},
{"condition-not-after", VariantType::Int64, 3385078236000ll, {"do not fetch from CCDB objects created after the timestamp"}},
{"condition-remap", VariantType::String, "", {"remap condition path in CCDB based on the provided string."}},
Expand Down
Loading