Repository navigation
ITS/MFT digi: fix for late hits seen by the next ROF - #16011
Merged
Merged
Conversation
shahor02
requested review from
f3sch,
fprino,
mconcas and
mcoquet642
as code owners
October 26, 2026 15:27
Collaborator
|
@shahor02 could this also be fwd'd to ITS3 digitiser, thanks! |
The timeInROF passed to registerDigits should be relative to the actual hit ROF not the collision ROF. Thanks to @atriolo for spotting
shahor02
force-pushed
the
pr_fix_tinROF
branch
from
October 26, 2026 17:30
5d1941b to
3bc54cb
Compare
Collaborator
Author
|
Added to the same commit. |
fprino
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The timeInROF passed to registerDigits should be relative to the actual hit ROF not the collision ROF.
Thanks to @atriolo for spotting,