Repository navigation
Conversation
This fixes a problem in the display mesh of O2BVHSurfaceSolid and adds a unit test. - Faces with inner wires were ear-clipped from their outer wire only, so holes and pipe bores were drawn filled. - Each hole is now bridged into the outer ring at a visible vertex before ear-clipping. - This applies to planar, curved-planar and wire-trimmed quadric faces. - Faces without holes keep their triangles unchanged. - Holes that touch or cross a wire cannot be bridged, so such faces are still drawn filled. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a problem in the display mesh of O2BVHSurfaceSolid and adds a unit test.