Repository navigation
[PWGLF] Added necessary histograms for Lambda feeddown + substituted boilerplate code with macros - #18061
Merged
Conversation
scannito
requested review from
alibuild,
ercolessi,
lhusova,
mpuccio,
omvazque,
romainschotter and
skundu692
as code owners
September 25, 2026 14:05
|
O2 linter results: ❌ 0 errors, |
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Two moderate correctness issues remain, including missing anti-Xi0 feeddown and incorrect anti-Lambda closure matching.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds Lambda feeddown histograms and refactors phi–strangeness correlation boilerplate using macros and arrays.
Changes:
- Adds Xi-to-Lambda and Xi-to-anti-Lambda feeddown histograms.
- Generalizes histogram, preslice, and mixed-event process definitions.
- Refactors MC closure particle handling.
| File | Summary | Review findings |
|---|---|---|
PWGLF/Tasks/Strangeness/phiStrangeCorrelation.cxx |
Refactors correlation setup and MC closure handling. | Anti-Lambda closure matching is incorrect; obsolete commented-out implementations should be removed. |
PWGLF/TableProducer/Strangeness/phiStrangeCorrelator.cxx |
Adds Xi feeddown histogram production. | Anti-Xi0 feeddown is not included in the anti-Lambda histogram. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
romainschotter
approved these changes
Sep 25, 2026
romainschotter
enabled auto-merge (squash)
September 25, 2026 14:40
scannito
added a commit
to scannito/O2Physics
that referenced
this pull request
Oct 16, 2026
Remove the code commented out in the previous PR (AliceO2Group#18061), the seven unused uniform-binning axes (multAxis and the pT axes, superseded by the binned ones) and the "TO BE REMOVED" tags on cutZVertex and vertexZAxis, which stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scannito
added a commit
to scannito/O2Physics
that referenced
this pull request
Oct 17, 2026
Remove the code commented out in the previous PR (AliceO2Group#18061), the seven unused uniform-binning axes (multAxis and the pT axes, superseded by the binned ones) and the "TO BE REMOVED" tags on cutZVertex and vertexZAxis, which stay. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.