Repository navigation
[PWGEM/PhotonMeson] Add Dalitz electron efficiency task - #18311
Merged
Merged
Conversation
lgansbartl
requested review from
alibuild,
amaringarcia,
dsekihat,
hscheid,
jokonig,
mhemmer-cern and
reygers
as code owners
October 15, 2026 10:51
|
O2 linter results: ❌ 0 errors, |
lgansbartl
added a commit
to lgansbartl/O2Physics
that referenced
this pull request
Oct 15, 2026
Please consider the following formatting changes to AliceO2Group#18311
lgansbartl
added a commit
to lgansbartl/O2Physics
that referenced
this pull request
Oct 15, 2026
Please consider the following formatting changes to AliceO2Group#18311
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
|
Hi @lgansbartl , Since you are adding a new file, please fix all reported errors and warnings so that the CI reports only new issues in the future PRs. |
mhemmer-cern
marked this pull request as draft
October 16, 2026 08:00
Collaborator
|
Converting to draft to stop test machines from retesting till the next commit with the fixes is coming. |
mhemmer-cern
marked this pull request as ready for review
October 21, 2026 08:43
Collaborator
|
Hi @lgansbartl , please consider fixing the warnings as well. |
mhemmer-cern
approved these changes
Oct 21, 2026
mhemmer-cern
left a comment
mhemmer-cern
left a comment
Collaborator
There was a problem hiding this comment.
Looks good now, the remaining O2 Linter warnings can be fixed in a separate PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.