Skip to content

[PWGHF] Cleanup of the correlatorDMesonPairs - #18313

Merged
apalasciano merged 16 commits into
AliceO2Group:masterfrom
atavirag:cleanup-double-d
Oct 16, 2026
Merged

[PWGHF] Cleanup of the correlatorDMesonPairs#18313
apalasciano merged 16 commits into
AliceO2Group:masterfrom
atavirag:cleanup-double-d

Conversation

@atavirag

@atavirag atavirag commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

Several modifications to update the code and make it more efficient and less error-prone:

  • Remove associated track information. The original idea with this was to extract the ME distribution with it, but this idea was finally revoked.
  • Separate functions so that each performs a single task.
  • New functions that perform kinematic and ML cuts to minimise code repetition.
  • MC rec and data processes are now performed using the same code with minimal changes.
  • DDbar and DbarD pairs are now grouped.

atavirag added 14 commits October 14, 2026 13:32
@atavirag
Move kinematic selections to a separate function
67ba4eb
@atavirag
unify flagD0(bar) selections for MC and data partitions
78363f4
@atavirag
Remove candidate groups (grouping should be done by default with selC…
91240e7 
…ollisionsWithD0)
@atavirag
Move analysePid to the main loop
dd55031
@atavirag
Reorganise functions to do one thing at a time
b713bd8 
- Removed fillEntry and fillEntryMc
- New function: setPairType
- New function: fillSelectionStatusHisto
- New function: fillMatchingHisto
- Restored selectionFlags (it didn't get the expected results)
@atavirag
New function: passMlSelections
3ffab58
@atavirag
Join McRec and Data processes --> processImpl
3dd8570
@atavirag
Add possibility to swap D Dbar candidates
f4d5593
@atavirag
Optimise MC gen function
70bb9be
@atavirag
reorder functions to improve readability
4cd0eb6
@atavirag
fix O2 linter
914a23c
@atavirag
remove unused configurables
be10cc5
@atavirag
Cleanup DmesonPairsTables.h
cec7a01
@atavirag
small fix
30831b8
@github-actions

github-actions Bot commented Oct 15, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Oct 15, 2026
Merged
@atavirag
Merge pull request #8 from alibuild/alibot-cleanup-18313
84723e8 
Please consider the following formatting changes to AliceO2Group#18313
@atavirag
atavirag marked this pull request as ready for review October 15, 2026 15:13
@alibuild

alibuild commented Oct 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 84723e8 at 2026-10-15 18:43:

No log files found

Full log here.

@apalasciano
apalasciano merged commit 9eae0c6 into AliceO2Group:master Oct 16, 2026
13 of 14 checks passed
@atavirag atavirag mentioned this pull request Oct 22, 2026
Closed
@atavirag
atavirag deleted the cleanup-double-d branch October 22, 2026 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apalasciano apalasciano apalasciano approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@vkucera vkucera Awaiting requested review from vkucera vkucera is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner
@xinyepeng xinyepeng Awaiting requested review from xinyepeng xinyepeng is a code owner
@singhra1994 singhra1994 Awaiting requested review from singhra1994 singhra1994 is a code owner

Assignees

No one assigned

Labels

datamodel pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@atavirag @alibuild @apalasciano