[Common] Track-Tuner calibrations for pp 2026 in autodetect. by mfaggin · Pull Request #18467 · AliceO2Group/O2Physics

mfaggin · 2026-10-26T15:41:03Z

No description provided.

github-actions · 2026-10-26T15:41:22Z

O2 linter results: ❌ 0 errors, ⚠️ 31 warnings, 🔕 0 disabled

alibuild · 2026-10-26T16:01:36Z

Error while checking build/O2Physics/code-check for 190f477 at 2026-10-26 17:01:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 36 warnings.'
Found 1 errors and 36 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/b6841db841a182c580371a9f0cef0c4f81dec4ba/O2Physics-code-check/errors.txt
Common/Tools/TrackTuner.h:639:50: error: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
++ [[ 36 -gt 0 ]]
++ cat /sw/BUILD/b6841db841a182c580371a9f0cef0c4f81dec4ba/O2Physics-code-check/warnings.txt
Common/Tools/TrackTuner.h:88:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:89:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:90:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:91:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:102:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:383:40: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:412:12: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/TrackTuner.h:414:19: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/TrackTuner.h:425:60: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:430:53: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:434:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:438:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:442:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:446:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:450:55: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:454:63: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:469:65: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:482:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:518:60: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:523:53: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:527:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:531:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:535:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:539:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:543:55: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:547:63: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:562:65: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:575:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:609:17: warning: unused local variable 'grOneOverPtPionNameMC' of type 'std::string' (aka 'basic_string<char>') [bugprone-unused-local-non-trivial-variable]
Common/Tools/TrackTuner.h:610:17: warning: unused local variable 'grOneOverPtPionNameData' of type 'std::string' (aka 'basic_string<char>') [bugprone-unused-local-non-trivial-variable]
Common/Tools/TrackTuner.h:661:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Common/Tools/TrackTuner.h:667:28: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:770:20: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

alibuild · 2026-10-26T16:07:17Z

Error while checking build/O2Physics/code-check for 71516ce at 2026-10-26 17:07:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 36 warnings.'
Found 1 errors and 36 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/c454780b1f83b8857c80eab039ec3f2dfa5d731e/O2Physics-code-check/errors.txt
Common/Tools/TrackTuner.h:639:50: error: Called C++ object pointer is null [clang-analyzer-core.CallAndMessage,-warnings-as-errors]
++ [[ 36 -gt 0 ]]
++ cat /sw/BUILD/c454780b1f83b8857c80eab039ec3f2dfa5d731e/O2Physics-code-check/warnings.txt
Common/Tools/TrackTuner.h:88:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:89:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:90:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:91:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:102:15: warning: redundant string initialization [readability-redundant-string-init]
Common/Tools/TrackTuner.h:383:40: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:412:12: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/TrackTuner.h:414:19: warning: do not use 'compare' to test equality of strings; use the string equality operator instead [readability-string-compare]
Common/Tools/TrackTuner.h:425:60: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:430:53: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:434:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:438:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:442:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:446:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:450:55: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:454:63: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:469:65: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:482:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:518:60: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:523:53: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:527:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:531:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:535:59: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:539:61: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:543:55: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:547:63: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:562:65: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
Common/Tools/TrackTuner.h:575:22: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:609:17: warning: unused local variable 'grOneOverPtPionNameMC' of type 'std::string' (aka 'basic_string<char>') [bugprone-unused-local-non-trivial-variable]
Common/Tools/TrackTuner.h:610:17: warning: unused local variable 'grOneOverPtPionNameData' of type 'std::string' (aka 'basic_string<char>') [bugprone-unused-local-non-trivial-variable]
Common/Tools/TrackTuner.h:661:5: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
Common/Tools/TrackTuner.h:667:28: warning: statement should be inside braces [readability-braces-around-statements]
Common/Tools/TrackTuner.h:770:20: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

Track-Tuner: add calibrations for pp 2026 in autodetect.

190f477

mfaggin requested review from a team, alibuild, ddobrigk, dsekihat, iarsene, jgrosseo and ktf as code owners October 26, 2026 15:41

github-actions Bot added the common label Oct 26, 2026

github-actions Bot changed the title ~~Common: Track-Tuner calibrations for pp 2026 in autodetect.~~ [Common] Track-Tuner calibrations for pp 2026 in autodetect. Oct 26, 2026

Fix calibration validity interval.

71516ce

Fix warnings.

ca134a4

dsekihat approved these changes Oct 27, 2026

View reviewed changes

Navigation Menu

Repository navigation

[Common] Track-Tuner calibrations for pp 2026 in autodetect. - #18467

[Common] Track-Tuner calibrations for pp 2026 in autodetect.#18467
mfaggin wants to merge 3 commits into
AliceO2Group:masterfrom
mfaggin:tt_pp2026

mfaggin commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

alibuild commented Oct 26, 2026

Uh oh!

alibuild commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

mfaggin commented Oct 26, 2026

Uh oh!

github-actions Bot commented Oct 26, 2026

Uh oh!

alibuild commented Oct 26, 2026

Uh oh!

alibuild commented Oct 26, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Milestone

Development

Uh oh!

3 participants