Skip to content

[PWGCF] adding switches for efficiency corrections - #18475

Open
mdaniel-14 wants to merge 2 commits into
AliceO2Group:masterfrom
mdaniel-14:master
Open

mdaniel-14 wants to merge 2 commits into
AliceO2Group:masterfrom
mdaniel-14:master

Conversation

@mdaniel-14

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 1 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title adding switches for efficiency corrections [PWGCF] adding switches for efficiency corrections Oct 27, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 52b66b8 at 2026-10-27 14:02:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 18 errors and 26 warnings.'
Found 18 errors and 26 warnings.
++ [[ 18 -gt 0 ]]
++ cat /sw/BUILD/1c00a3c9ca5aa1e4cff0f427b81907a7567a95cc/O2Physics-code-check/errors.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:18:1: error: included header EventSelectionParams.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:28:1: error: included header DataTypes.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:49:1: error: included header TH1D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:50:1: error: included header TH1F.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:51:1: error: included header TH2F.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:113:3: error: no header providing "o2::framework::OutputObj" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:114:30: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:115:30: error: no header providing "o2::framework::OutputObjSourceType" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:120:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:124:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:171:38: error: no header providing "NULL" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:173:5: error: no header providing "TH1F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:189:5: error: no header providing "TH2F" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:236:3: error: no header providing "TObject" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:269:5: error: no header providing "TIter" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:549:10: error: no header providing "int64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:608:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:821:3: error: no header providing "PROCESS_SWITCH" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 26 -gt 0 ]]
++ cat /sw/BUILD/1c00a3c9ca5aa1e4cff0f427b81907a7567a95cc/O2Physics-code-check/warnings.txt
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:109:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:153:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:163:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:164:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:173:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:181:5: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:258:14: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:268:14: warning: variable 'objectIter' is not initialized [cppcoreguidelines-init-variables]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:273:41: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:274:25: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:279:12: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:288:18: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:289:23: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:290:27: warning: use nullptr [modernize-use-nullptr]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:332:22: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
PWGCF/MultiparticleCorrelations/Tasks/multiparticleCorrelationsDm.cxx:336:24: warning: do not use reinterpret_cast [cppcoreguidelines-pro-type-reinterpret-cast]
[0 more errors; see full log]

Full log here.

@abilandz abilandz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdaniel-14 Are you sure you pushed all comits? I do not see here any new code where you have added the new switches?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants