Repository navigation
[OGUI-1906] Notification pauses on hover and allows copying - #3513
Merged
isaachilly merged 19 commits intoOct 26, 2026
Merged
Conversation
isaachilly
marked this pull request as draft
June 16, 2026 14:33
isaachilly
force-pushed
the
improv/FRM/OGUI-1906/Notification-hover-and-copy
branch
from
October 21, 2026 15:12
69be414 to
800d1b6
Compare
isaachilly
changed the base branch from
dev
to
improv/FRM/OGUI-1934/Centralise-clipboard-behaviour
October 21, 2026 15:29
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
isaachilly
force-pushed
the
improv/FRM/OGUI-1906/Notification-hover-and-copy
branch
2 times, most recently
from
October 22, 2026 14:52
27104dc to
8f3dd3a
Compare
isaachilly
marked this pull request as ready for review
October 22, 2026 15:27
graduta
requested changes
Oct 26, 2026
graduta
left a comment
graduta
left a comment
Member
There was a problem hiding this comment.
In terms of UI, I think it would be good to let the user know that when they hover the notification they have the option to click. Not only with the mouse over pointer but also a darker background similar to what we do for buttons. What do you think?
Base automatically changed from
improv/FRM/OGUI-1934/Centralise-clipboard-behaviour
to
dev
October 26, 2026 12:43
Notifications now pause auto-hide while hovered, so users have time to read longer or normal message at their leisure. Added a copy-to-clipboard button inside the notification, flush with the right edge, that copies the message and displays a new "Text copied to clipboard" notification when clicked.
Adds tests for pause-on-hover and copy functionality. Adjusts queryRouter cllass test so that `window.notification` isn't being overwritten making notification class less simple to test,
Copy state now lives within the copy button through use of different icons and notification model attributes. Adjust tests to the functionality. Restructure tests to be one describe with 2 child blocks.
Extract clearTimeouts() and startHideTimer() helpers to remove duplicated timer logic. hide() now also resets the hovered flag. Copy now uses the shared copyToClipboard utility, so it falls back to 'failed' when the clipboard is unavailable. The copy-state reset delay is configurable via copyDuration.
isaachilly
force-pushed
the
improv/FRM/OGUI-1906/Notification-hover-and-copy
branch
from
October 26, 2026 12:43
0e9a015 to
8ae3c97
Compare
Collaborator
Author
Agreed, it makes it more obvious that there's an action available. The message part now darkens on hover by the same step as the copy button, and lightens slightly when pressed. |
graduta
self-requested a review
October 26, 2026 14:23
graduta
approved these changes
Oct 26, 2026
isaachilly
deleted the
improv/FRM/OGUI-1906/Notification-hover-and-copy
branch
October 26, 2026 14:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have JIRA issue created
Ticket:
As a user, I would like to be able to stop notifications from closing when I'm still reading/understanding them.
On a similar note being able to copy the message is useful too.
Code:
Adds an integrated copy button to the notification element.
Adds timer and state logic for copy button.
Refactors notification class to be more readable.
Adds more comprehensive copy button tests.
Reviewer:
To test the new look the reviewer can create a notification with
notification.show('Notification Text', 'danger', 5000). Remember to use local Web-UI version.