Skip to content

Raise the minimum AngleSharp version to 1.9.1 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
michaelthyregod wants to merge 2 commits into from
Closed

Raise the minimum AngleSharp version to 1.9.1 #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c66bcd
Raise the minimum AngleSharp version to 1.9.1
michaelthyregod Nov 2, 2026
80c7491
Add the PR number to the CHANGELOG entry
michaelthyregod Nov 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
10.0.x

- name: Build
run: ./build.sh -AngleSharpVersion 1.9.0
run: ./build.sh -AngleSharpVersion 1.9.1

windows:
runs-on: windows-latest
Expand Down Expand Up @@ -87,9 +87,9 @@ jobs:
NUGET_API_KEY: ${{ steps.nuget_login.outputs.NUGET_API_KEY }}
run: |
if ($env:GITHUB_REF -eq "refs/heads/main") {
.\build.ps1 -Target Publish -AngleSharpVersion 1.9.0
.\build.ps1 -Target Publish -AngleSharpVersion 1.9.1
} elseif ($env:GITHUB_REF -eq "refs/heads/devel") {
.\build.ps1 -Target PrePublish -AngleSharpVersion 1.9.0
.\build.ps1 -Target PrePublish -AngleSharpVersion 1.9.1
} else {
.\build.ps1 -AngleSharpVersion 1.9.0
.\build.ps1 -AngleSharpVersion 1.9.1
}
4 changes: 2 additions & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,15 @@ dotnet run --project src/AngleSharp.Performance.Css/AngleSharp.Performance.Css.c

Notes:

- CI invokes `./build.sh -AngleSharpVersion 1.9.0` on Linux and `./build.ps1` on Windows.
- CI invokes `./build.sh -AngleSharpVersion 1.9.1` on Linux and `./build.ps1` on Windows.
- Treat warnings as errors is enabled in `src/Directory.Build.props`.

## 3) Build and target framework facts

- Library project: `src/AngleSharp.Css/AngleSharp.Css.csproj`
- Targets: `netstandard2.0;net8.0;net10.0`
- Additional Windows-only targets: `net462;net472`
- The AngleSharp dependency defaults to version `1.9.0` and allows versions below `2.0.0`.
- The AngleSharp dependency defaults to version `1.9.1` and allows versions below `2.0.0`.
- The `net8.0` and `net10.0` targets set `IsAotCompatible`, so trim and AOT analyzer warnings fail the build.
- Test project: `src/AngleSharp.Css.Tests/AngleSharp.Css.Tests.csproj`
- Targets: `net8.0`
Expand Down
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Released on Monday, November 2 2026.
- Improved the parser with a nesting limit for values and conditions (`MaxValueNestingDepth`) (#260) @michaelthyregod
- Improved indexing rules with deeply nested `:is()`, `:where()`, or `:matches()` (#261) @michaelthyregod
- Improved reading inherited properties on deep trees (e.g. `visibility` in `IsVisible` and `GetInnerText`) (#263) @michaelthyregod
- Updated to use a minimum of AngleSharp 1.9.1 (#264) @michaelthyregod

# 1.3.1

Expand Down
2 changes: 1 addition & 1 deletion src/AngleSharp.Css/AngleSharp.Css.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<AngleSharpVersion Condition=" '$(AngleSharpVersion)' == '' ">1.9.0</AngleSharpVersion>
<AngleSharpVersion Condition=" '$(AngleSharpVersion)' == '' ">1.9.1</AngleSharpVersion>
</PropertyGroup>

<ItemGroup>
Expand Down
Loading