Repository navigation
Honor configured regex timeouts in prepared scripts - #146
Merged
FlorianRappl merged 2 commits intoOct 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of Changes
Prerequisites
Contribution Type
Description
An
EngineCreatorconfigured with a 37 ms regex timeout currently produces regular-expression literals whoseMatchTimeoutis ten seconds.ScriptCacheprepares them with Jint's defaults instead of the configured timeout.This passes the timeout into script preparation and includes it in the cache key. Engines with the same source and timeout still share a prepared script; engines with different timeouts keep their own policy. The existing cache capacity and syntax-error fallback are unchanged.
The regression tests cover inline and explicit scripts, both orders of two different engine timeouts, and reuse of the first timeout. All four new cases fail against unchanged
devel. Temporarily removing the timeout from cache identity also makes both cross-engine cases fail.Validation: 317 offline tests pass on .NET 10, and all ten engine-configuration tests pass on .NET Framework 4.6.2 and 4.7.2. All five library targets build with zero warnings. The network-dependent
IntegrationTestsandPageTestsfixtures were not run locally.