Repository navigation
ci: close the issues a pull request names once it reaches dev - #1982
Open
swapnilpaliwal-sd wants to merge 1 commit into
Open
swapnilpaliwal-sd wants to merge 1 commit into
swapnilpaliwal-sd wants to merge 1 commit into
Conversation
…er branch it merged into GitHub closes issues from "Closes #N" only when the merge lands on the default branch. Pull requests into integration or release branches (0.2.1, apps/integration-*) leave their issues open after the work reaches dev. On each push to dev this closes them, with a comment naming the pull request. "Part of #N" and "Refs #N" are not closing words, so umbrella issues stay open. Manual runs are dry runs by default.
swapnilpaliwal-sd
requested review from
JaredHLZhang,
Whua689 and
suyashpaliwal26
as code owners
October 15, 2026 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1983
Symptom
A pull request that merges into an integration or release branch (
0.2.1,apps/integration-*, a perf branch) never closes the issues it names. GitHub acts onCloses #Nonly when the merge lands on the default branch, so after the work reachesdevthe issues stay open by hand.Three are stuck that way today: #1869, #1935 and #1939. Their pull requests (#1872, #1936, #1940) merged into integration branches and are part of
dev.Change
.github/workflows/close-issues-on-dev.ymlruns on every push todevand calls.github/scripts/close-issues-on-dev.sh, which:dev;dev;Closes/Fixes/Resolves #N), with a comment naming the pull request and the commit.Part of #NandRefs #Nare not closing words, so umbrella issues stay open. A manual run (workflow_dispatch) is a dry run by default and only lists what it would close.Checked
DRY_RUN=1 .github/scripts/close-issues-on-dev.shagainst this repository lists exactly the three issues above and nothing else; each was confirmed open with its pull request merged and ondev.