Skip to content

Forward x-ms-copy-source-authorization when reading a copy source (issue #2815) - #2876

Open
Ankit Chaudhary (ankit1324) wants to merge 2 commits into
Azure:mainfrom
ankit1324:fix/copy-source-authorization
Open

Ankit Chaudhary (ankit1324) wants to merge 2 commits into
Azure:mainfrom
ankit1324:fix/copy-source-authorization

Conversation

@ankit1324

@ankit1324 Ankit Chaudhary (ankit1324) commented Oct 29, 2026 •

Copy link
Copy Markdown

Fixes #2815

What was wrong

Put Blob From URL and Put Block From URL read the source with a loopback request in BlockBlobHandler.readCopySource. That request only sends host, accept-encoding and the range and source-condition headers. The generated layer parses options.copySourceAuthorization, but no handler used it. With --oauth basic, a private source failed with 403 CannotVerifyCopySource even when x-ms-copy-source-authorization: Bearer <token> carried a valid token. Only a public container or a SAS in the source URL worked.

What the fix does

When x-ms-copy-source-authorization carries a Bearer token, it becomes the Authorization header of the loopback source read. The token authenticator then checks it the same way it checks a direct request. This covers the content read of both operations, plus the tags read that Put Blob From URL does for x-ms-copy-source-tag-option: COPY. The handler does not log the value. The loopback URL is still pinned to this server's own address, so the token never goes to a host the caller chose.

Only the Bearer scheme is forwarded. The scheme is matched case-insensitively (RFC 9110) and sent on as Bearer, because the token authenticator only recognises that spelling. Any other scheme fails the request with 400 InvalidHeaderValue naming x-ms-copy-source-authorization, before the source is read. The error does not include the header value. Forwarding every scheme would let a SharedKey signature computed for the loopback GET authorize the read, even on a server started without --oauth.

On the error choice: the REST docs for Put Blob From URL, Put Block From URL and Copy Blob From URL say only the Bearer scheme is supported for this header, but don't say what Azure returns for other schemes. I couldn't find an SDK test or recording that sends a non-Bearer scheme either. The closest data point is the .NET SDK's *_SourceBearerTokenFail tests (BlobBaseClientTests.cs, BlockBlobClientTests.cs). They send Bearer auth token and expect CannotVerifyCopySource. That covers a bad Bearer value, not another scheme, so I used Azurite's existing InvalidHeaderValue error. Happy to switch to 400 CannotVerifyCopySource if you prefer.

Without the header, or with an empty one, nothing changes. A SAS in the source URL still takes precedence, because the SAS authenticators run before the token one. A token the server rejects, or a server started without --oauth, still gives CannotVerifyCopySource.

Copy Blob From URL

The issue also mentions Copy Blob From URL, which I left out of this change. In Azurite, BlobHandler.copyFromURL only calls validateCopySource when the source is in a different account. A same-account private source therefore already copies without any source authorization, which is more permissive than Azure. For cross-account sources, validateCopySource also drops the header. Testing that needs a second account, so it seemed better as a separate follow-up. I'm happy to do it if you want.

Tests

New tests in tests/blob/oauth.test.ts:

  • Put Blob From URL, Put Blob From URL with tag COPY, and Put Block From URL from a private source with a bearer sourceAuthorization. All three fail on main with CannotVerifyCopySource and pass with the fix.
  • An expired but otherwise valid source token is rejected with CannotVerifyCopySource and status 403. The token is generated with the same claims as the valid tokens except exp, so the token authenticator's lifetime check is what rejects it.
  • A private source with a valid SAS in its URL and a bogus x-ms-copy-source-authorization still copies.
  • A lowercase bearer scheme authorizes the copy, as Bearer does.
  • A correctly signed SharedKey source credential for the loopback read (computed with the emulator account key) does not authorize Put Blob From URL or Put Block From URL. Both fail with 400 InvalidHeaderValue, and the error message does not contain the signature. Before this change, both copies succeeded.

npm run lint and npm run build are clean. The blob suite (test:blob without the lint step) gives 625 passing, 3 pending and 0 failing. oauth and blockblob also pass with AZURITE_TEST_INMEMORYPERSISTENCE=1.

Checklist

  • PR targets main (Azurite V3).
  • Test cases added to cover the change.
  • Change log added under Upcoming Release in ChangeLog.md.

I'll sign the Microsoft CLA when the bot asks.

…sue Azure#2815)

Put Blob From URL and Put Block From URL read the source with a loopback request that carried no credential, so a private source failed with CannotVerifyCopySource even with a valid bearer token in x-ms-copy-source-authorization. Send that header as the Authorization header of the source read, including the tags read for x-ms-copy-source-tag-option: COPY.
Copilot AI balanced review requested due to automatic review settings October 29, 2026 11:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both copy operations accept correctly signed SharedKey source credentials despite Azure’s Bearer-only restriction, allowing private-source authorization even when OAuth is disabled.

1 open issue
What changed in this PR

Addresses issue #2815 for Put Blob From URL and Put Block From URL by forwarding source authorization through Azurite’s existing authentication path. Copy Blob From URL remains outside this change.

Changes:

  • Forward source authorization for content reads and optional source-tag copying.
  • Add OAuth tests for successful copies, expired-token rejection, and SAS precedence.
  • Document the behavior under Upcoming Release.

Validation here was limited to code inspection; builds and tests were not run.

File Description
tests/​blob/​oauth.test.ts Adds five source-authorization regression tests.
src/​blob/​handlers/​BlockBlobHandler.ts Forwards source credentials for blob, block, and tag reads.
ChangeLog.md Records the source-authorization fix for both operations.

Review effort: Balanced

Comment thread src/blob/handlers/BlockBlobHandler.ts Resolved
Copilot AI balanced review requested due to automatic review settings October 29, 2026 12:00
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

Ankit Chaudhary (@ankit1324) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified for the scoped bearer-token source-authorization change.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Blob] x-ms-copy-source-authorization is ignored, so a copy source authorized by a bearer token is refused

2 participants