Skip to content

WCN-1565: Pass attestation through MPC signing - #10072

Merged
mohammadalfaiyazbitgo merged 3 commits into
masterfrom
wcn-1565/mpc-attestation-passthrough
Oct 28, 2026
Merged

WCN-1565: Pass attestation through MPC signing#10072
mohammadalfaiyazbitgo merged 3 commits into
masterfrom
wcn-1565/mpc-attestation-passthrough

Conversation

@mohammadalfaiyazbitgo

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

  • Accept optional attestation in Express withdrawal/TSS request schemas and thread it through SDK wallet options.
  • Send attestation top-level on withdrawal /txrequests and on only the first legacy /signatureshares or MPCv2 /sign submission.
  • Keep pass-through only; SDK and Express do not verify attestation.

Verification

  • Express typed-route tests: 165 passing.
  • TSS withdrawal body tests: 3 passing; legacy ECDSA/EdDSA and MPCv2 ECDSA/EdDSA first-round tests: 4 passing each.
  • Changed-file Prettier and ESLint checks passed; commitlint passed.
  • SDK Core Mocha tests remain blocked by the module loading error: Cannot access BaseTssUtils before initialization. Broader workspace runs also hit unrelated dependency/build issues.

@linear-code

linear-code Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

WCN-1565

mohammadalfaiyazbitgo
mohammadalfaiyazbitgo commented Oct 27, 2026
View reviewed changes

@mohammadalfaiyazbitgo mohammadalfaiyazbitgo left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

@github-actions

github-actions Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run

@mohammadalfaiyazbitgo
mohammadalfaiyazbitgo marked this pull request as ready for review October 27, 2026 02:43
@mohammadalfaiyazbitgo
mohammadalfaiyazbitgo requested review from a team as code owners October 27, 2026 02:43
claude[bot]
claude Bot reviewed Oct 27, 2026
View reviewed changes

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

Tip: disable this comment in your organization's Code Review settings.

pranavjain97
pranavjain97 previously approved these changes Oct 27, 2026
View reviewed changes
Comment thread modules/express/test/unit/typedRoutes/sendCoins.ts
s84krish
s84krish previously approved these changes Oct 27, 2026
View reviewed changes

@s84krish s84krish left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, non blocking comments

Comment thread modules/bitgo/test/v2/unit/wallet.ts
Comment thread modules/express/test/unit/typedRoutes/sendCoins.ts Outdated
@mohammadalfaiyazbitgo
feat(sdk-core): pass attestation through MPC signing
73150fc 
References: WCN-1565
@mohammadalfaiyazbitgo
fix(sdk-core): skip round-one attestation after txrequest creation
906f4bb 
Wallet Platform consumes the attestation nonce at txRequest creation.

Resending it on round one triggers a failed re-capture.

References: WCN-1565
@mohammadalfaiyazbitgo
test: consolidate MPC attestation coverage
49d4412 
Combine the PR test follow-ups into one test commit.

References: WCN-1565
@mohammadalfaiyazbitgo
mohammadalfaiyazbitgo force-pushed the wcn-1565/mpc-attestation-passthrough branch from 77e2fc2 to 49d4412 Compare October 27, 2026 19:49
rishikeshdadam136
rishikeshdadam136 reviewed Oct 28, 2026
View reviewed changes

@rishikeshdadam136 rishikeshdadam136 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

@mohammadalfaiyazbitgo
mohammadalfaiyazbitgo merged commit 42039fb into master Oct 28, 2026
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments
@rishikeshdadam136 rishikeshdadam136 rishikeshdadam136 approved these changes
@Charan-Ratlan Charan-Ratlan Awaiting requested review from Charan-Ratlan Charan-Ratlan is a code owner automatically assigned from BitGo/wallet-core-india
@pranavjain97 pranavjain97 Awaiting requested review from pranavjain97
@s84krish s84krish Awaiting requested review from s84krish

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mohammadalfaiyazbitgo @pranavjain97 @s84krish @rishikeshdadam136