Repository navigation
fix(sdk-coin-canton): receive-only allocate amount in any order - #10084
Open
hrishikeshjain wants to merge 1 commit into
Open
hrishikeshjain wants to merge 1 commit into
hrishikeshjain wants to merge 1 commit into
Conversation
AllocationAllocateBuilder.amount() rejected a zero amount unless allocationRole('receive') had already been called, and the thrown message said nothing about that escape hatch. Wallet-platform builds the receive-only (cross-issuer V2) allocate with amount '0' and never calls allocationRole(), so accepting a receive-only offer 500s with "amount must be a positive number" (staging requestId bg25-uiff0806084d96ac2cdcea-0001).
amount() now normalizes with allowZero=true, so the two calls can be made in either order; the rule that zero is only valid for a receive-only allocation moved into validate(), where the request object is built, and the error now names allocationRole('receive'). Negative, empty and non-numeric amounts are still rejected immediately, and a send allocation with a zero amount still throws. normalizeCantonAmount behaviour for the other canton builders is unchanged.
Ticket: CHALO-1993
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
Contributor
|
|
ravibitgo
approved these changes
Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AllocationAllocateBuilder.amount() rejected a zero amount unless allocationRole('receive') had already been called, and the thrown message said nothing about that escape hatch. Wallet-platform builds the receive-only (cross-issuer V2) allocate with amount '0' and never calls allocationRole(), so accepting a receive-only offer 500s with "amount must be a positive number" (staging requestId bg25-uiff0806084d96ac2cdcea-0001).
amount() now normalizes with allowZero=true, so the two calls can be made in either order; the rule that zero is only valid for a receive-only allocation moved into validate(), where the request object is built, and the error now names allocationRole('receive'). Negative, empty and non-numeric amounts are still rejected immediately, and a send allocation with a zero amount still throws. normalizeCantonAmount behaviour for the other canton builders is unchanged.
Ticket: CHALO-1993