Repository navigation
feat: add eddsaMpc and XLM Safe recovery key params - #10090
Open
danielpeng1 wants to merge 1 commit into
Open
danielpeng1 wants to merge 1 commit into
danielpeng1 wants to merge 1 commit into
Conversation
Contributor
Contributor
|
|
danielpeng1
force-pushed
the
WCN-3914-safe-recovery-eddsampc-xlm
branch
from
October 29, 2026 05:20
4e2249e to
d5ca9d0
Compare
danielpeng1
force-pushed
the
WCN-3914-safe-recovery-eddsampc-xlm
branch
from
October 29, 2026 13:56
d5ca9d0 to
46da21b
Compare
danielpeng1
marked this pull request as ready for review
October 29, 2026 14:47
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildSafeRecoverKeyParamsturns derived Safe child keys into the params a coin'srecover()expects. It threw foreddsaMpcwallets (SOL, ADA, etc.) and for XLM, so those couldn't be recovered. This adds both.eddsaMpc (slot ④)
eddsaMpcbranch. Signed mode re-encrypts the child shares under a throwaway passphrase; unsigned mode returns only the child common keychain. Both always setisTss: trueandbroadcast: false.MpcSafeRecoverKeyParams<Slot>type and builder betweenecdsaMpcandeddsaMpc.EcdsaMpcSafeRecoverKeyParamskeeps its shape.XLM (slot ②,
ed25519Multisig)xlmandtxlmin theed25519Multisigencoders.rootAddressis not derived (as with HBAR), so the caller still supplies it.Tests
eddsaMpc
sdk-coresafe/recovery.ts: the MPC signed and unsigned tests now run for bothecdsaMpcandeddsaMpc.solSafeRecovery.tsandadaSafeRecovery.ts: derive, build, then run the realrecover()with real MPS signing. Signed signatures verify under the derived key, unsigned sweeps spend from the derived address, and shares from the wrong account are rejected.XLM
sdk-coresafe/recovery.ts: XLM/TXLM golden vectors (signed and unsigned).xlmSafeRecovery.ts: signed recovery through the lazy backup signer with both signatures verified, unsigned recovery with no encrypt or decrypt, andRecoveryKeyMismatchErrorwhen the derived keys aren't account signers.Ticket: WCN-3914