Skip to content

ci: restore Claude reviews with a supported Bedrock model - #288

Closed
ralph-bitgo[bot] wants to merge 1 commit into
masterfrom
WAL-2202-fix-claude-reviews
Closed

ralph-bitgo[bot] wants to merge 1 commit into
masterfrom
WAL-2202-fix-claude-reviews

Conversation

@ralph-bitgo

@ralph-bitgo ralph-bitgo Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

What

  • Upgrade the pinned Claude action to v1.0.260 and select the active Sonnet 5.5 global Bedrock inference profile with ANTHROPIC_MODEL in both Claude paths.
  • Migrate bare @claude reviews to the supported prompt input and allow the GitHub CLI tools needed to read and post reviews.
  • Make the review commands target the triggering repository and pull request explicitly.
  • Keep custom mentions in interactive mode with comment and conversation context.
  • Disable extended thinking because Bedrock rejects replayed tool-call turns without a leading thinking block.
  • Replace the ignored timeout_minutes input with a ten-minute job timeout and document operation in .github/README.md.
  • Leave AWS roles, region, permissions, and application code unchanged.

Why

Claude reviews fail because the previous model reached end of life. The old action inputs are ignored, and comment-triggered runs start from the default branch, so the workflow also needs supported inputs and explicit pull-request targeting.

The linked BitGoJS failure showed that action v1.0.194 carried Claude Code 2.1.234, while Sonnet 5.5 requires 2.1.280 or newer. Action v1.0.260 carries Claude Agent SDK 0.3.309 and a sufficiently new Claude Code runtime.

Test plan

  • actionlint -shellcheck= .github/workflows/claude-code.yaml passed using the BitGoJS locked Nix tool source.
  • Targeted harness verified action v1.0.260, the global Sonnet 5.5 profile, MAX_THINKING_TOKENS=0, the ten-minute timeout, explicit GitHub CLI targeting, removal of obsolete inputs, and prompt selection for bare, whitespace-padded, and custom mentions.
  • Verified prompt-versus-interactive mode behavior and accepted inputs against the pinned action source.
  • Verified the pinned action carries Claude Agent SDK 0.3.309.
  • After merge, invoke a bare @claude review and a custom mention; confirm successful inference and posted feedback. Comment-triggered workflows use the default branch definition, so live end-to-end verification cannot run from this PR branch.

Application builds and unit tests are not applicable to this workflow-only change. The inference role must allow the global Sonnet 5.5 profile and its destination models.

Ticket: WAL-2202

@linear-code

linear-code Bot commented Oct 20, 2026

Copy link
Copy Markdown

WAL-2202

@zahin-mohammad
zahin-mohammad force-pushed the WAL-2202-fix-claude-reviews branch 3 times, most recently from 5f1de50 to 515c67f Compare October 23, 2026 23:37
@zahin-mohammad

zahin-mohammad commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

AI-generated review — updated after validating the linked Sonnet 5.5 failure. Please use your own judgment before acting on any findings.


PR Review: #288 — restore Claude reviews with Sonnet 5.5

Changes: +34 / -9 across 2 files

Summary

This PR upgrades both review modes to claude-code-action v1.0.260, whose Claude Agent software development kit (SDK) dependency is 0.3.309, and selects the global Sonnet 5.5 Bedrock inference profile (.github/workflows/claude-code.yaml:84, .github/workflows/claude-code.yaml:87, .github/workflows/claude-code.yaml:107, .github/workflows/claude-code.yaml:110).

flowchart TD
    A[Owner or member comments @claude] --> B{Bare mention?}
    B -->|Yes| C[Load prompts/code-review.md]
    B -->|No| D[Preserve conversation context]
    C --> E[claude-code-action v1.0.260]
    D --> E
    E --> F[Global Bedrock Sonnet 5.5]
    F --> G[Post review to triggering pull request]
Loading

Findings

  • ✅ Fixed: action v1.0.194 carried Claude Code 2.1.234, which the linked run showed cannot invoke Sonnet 5.5. The new pin carries SDK 0.3.309.
  • ✅ Fixed: the profile now uses AWS's global Sonnet 5.5 identifier instead of the US-only profile (.github/workflows/claude-code.yaml:87).
  • ✅ Fixed: review commands explicitly target the triggering repository and PR (.github/workflows/claude-code.yaml:101).
  • ✅ Aligned with WAL-2202: bare reviews and interactive mentions retain their intended modes.

Verification

actionlint: PASS
latest-action/profile harness: PASS
commitlint: 0 errors
Mermaid render: PASS (202490 bytes)

Remaining live check: comment-triggered workflows use the default-branch definition, so actual Bedrock inference must be verified after merge (.github/README.md:15). The inference role must permit the global profile and its worldwide destination-model resources.


Generated by the wallet-platform:review-pr skill

@zahin-mohammad
zahin-mohammad force-pushed the WAL-2202-fix-claude-reviews branch from 515c67f to dfa2b07 Compare October 23, 2026 23:41
Upgrade the pinned Claude action to v1.0.260 and select the global Sonnet 5.5 profile.

The action carries Claude Agent SDK 0.3.309, which supports the selected model.

Disable extended thinking for tool-call replay compatibility. Keep custom mentions interactive.

Restore the ten-minute timeout and target the triggering pull request explicitly.

Ticket: WAL-2202

Session-Id: 146db0fb-b94c-4d9e-806e-4c150d26cfd3

Task-Id: e2770251-64bd-49f8-9e3f-2606f7e17c68

Requested-By: Zahin Mohammad <zahinmohammad@bitgo.com>
@zahin-mohammad
zahin-mohammad force-pushed the WAL-2202-fix-claude-reviews branch from dfa2b07 to 67a5d1c Compare October 23, 2026 23:43
@zahin-mohammad

Copy link
Copy Markdown
Contributor

Recreated under @zahin-mohammad as #297.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants