Repository navigation
Feature: Hosts File Editor bulk edit comments, enable/disable, and delete entries - #3624
Merged
mergify[bot] merged 2 commits intoOct 19, 2026
Conversation
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
BornToBeRoot
requested review from
BornToBeRoot
and
a balanced review from Copilot
October 18, 2026 15:20
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Batch updates and deletions can silently commit partial changes and report success when selected entries are missing.
2 open issues
1 file not reviewed
Source/NETworkManager.Localization/Resources/Strings.Designer.cs: Generated file
What changed in this PR
Adds bulk entry management to NETworkManager’s Hosts File Editor.
Changes:
- Adds batch enable, disable, comment editing, and deletion with one backup and write per batch.
- Connects multi-selection commands, keyboard actions, and confirmation dialogs.
- Adds a comment editor and localized labels.
| File | Description |
|---|---|
| Source/NETworkManager/Views/HostsFileEditorView.xaml | Adds bulk context-menu actions. |
| Source/NETworkManager/Views/HostsFileEditorCommentChildWindow.xaml.cs | Focuses the comment input. |
| Source/NETworkManager/Views/HostsFileEditorCommentChildWindow.xaml | Defines the comment dialog. |
| Source/NETworkManager/ViewModels/HostsFileEditorViewModel.cs | Handles multi-selection operations and dialogs. |
| Source/NETworkManager/ViewModels/HostsFileEditorCommentViewModel.cs | Manages comment input and commands. |
| Source/NETworkManager.Models/HostsFileEditor/HostsFileEditor.cs | Implements batch file operations. |
| Source/NETworkManager.Localization/Resources/Strings.resx | Adds labels and deletion confirmation text. |
| Source/NETworkManager.Localization/Resources/Strings.Designer.cs | Exposes the new localized strings. |
Review effort: Balanced
| } | ||
|
|
||
| if (!entryFound) | ||
| if (!anyModified && entriesList.Count > 0) |
| } | ||
|
|
||
| if (!entryFound) | ||
| if (!anyDeleted && entriesList.Count > 0) |
BornToBeRoot
added
🚀 feature-request
📖 documentation
🦀 Claude
and removed
🦀 Claude
labels
Owner
|
@omrzgit thanks. I applied some changes from the code review and re-used the existing dialog. I will merge it once the CI is done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
Summary
This PR enables bulk management of entries in the Hosts File Editor. Previously, when multiple items were selected in the DataGrid, only the "Export..." option was available. Now users can enable, disable, edit comments, or delete multiple hosts entries simultaneously in a single atomic file operation.
Contributing
By submitting this pull request, I confirm the following: