Repository navigation
fix: let every PR hygiene run complete - #209
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207
Problem
pr-hygiene.ymlcancelled every run but the last within its concurrency group (cancel-in-progress: true): 152 of the 200 runs before this PR. "Labels and issue link" is a required check onrelease/5.xandmain, and each cancelled run left a CANCELLED check run on the commit.Change
Keeps the group and sets
cancel-in-progress: false, so the runs of one PR go one at a time and none that has started is cancelled. The workflow's header comment records why, from the measurements below.Tests
Measured on #208 (the same change into
release/5.x), then again on this PR intomain:No group (first commit, d80aa07). Opened with labels, milestone and body in one
gh pr create: four runs, all completed, none cancelled. Then the failure the issue warned of: a label removed and re-added gave a failing run and a passing one; re-running the failing run, so its old payload finished last, made FAILURE the check's latest result although the labels were in order. Without a group, runs finish in any order, and the last to finish decides.Serialized (cb3145d). A push, then three remove/add pairs of a label within 4 seconds: seven runs. They ran in event order, the last event's run (passing) finished last at 14:58:48, and the three runs cancelled while waiting left no check run on the commit. The commit's "Labels and issue link" check runs: success, failure, failure, success, in that order, the last deciding.
This PR into
main. Opened with labels, milestone and body, then three remove/add pairs of a label: ten runs, five cancelled while waiting, five check runs on the commit, none cancelled, the last a success finishing last.So a cancelled run can still appear in the Actions list, but only one that never started, and never as a check run.
🤖 Generated with Claude Code