Repository navigation
IRSA-8038: Euclid DR1 support Datalink support - #2047
Merged
Merged
Conversation
jaladh-singhal
approved these changes
Oct 23, 2026
| const colName= p.colName || getColumnByRef(table, p.ref)?.name; | ||
| sendParams[p.name]=getCellValue(table, row, colName); | ||
| } | ||
| else if (isDefined(p.value) && p.value!=='') { // fixed value set by the service descriptor, e.g. RELEASE=dr1 |
Member
There was a problem hiding this comment.
Suggested change
| else if (isDefined(p.value) && p.value!=='') { // fixed value set by the service descriptor, e.g. RELEASE=dr1 | |
| else if (p.value) { // fixed value set by the service descriptor, e.g. RELEASE=dr1 |
Maybe the truthy check is enough if it's going be a string? You know context better though.
kpuriIpac
force-pushed
the
IRSA-8038-euclid-dr1
branch
from
October 27, 2026 00:10
f823f20 to
14ab91e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: IRSA-8038
makeDlUrlonly sent service descriptor params that reference a column, dropping fixed-value ones.RELEASE/CATALOGvalues (without them the service defaults to Q1 and returns 400), so fixed-value params are now sent too.