Skip to content

Firefly-2122: improve HiPS accuracy around poles - #2050

Merged
robyww merged 1 commit into
devfrom
FIREFLY-2122-more-hips-accuracy
Oct 28, 2026
Merged

robyww merged 1 commit into
devfrom
FIREFLY-2122-more-hips-accuracy

Conversation

@robyww

@robyww robyww commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Firefly-2122: improve HiPS accuracy around poles

  • HiPS is more accurate to the FITS around the poles

Note: the wcs match does not work very well when really close to the poles, but the is a future task

Testing

@robyww
robyww requested a review from tgoldina October 26, 2026 20:51
@robyww robyww self-assigned this Oct 26, 2026
@robyww
robyww force-pushed the FIREFLY-2122-more-hips-accuracy branch from a306a37 to e608860 Compare October 27, 2026 20:58

@tgoldina tgoldina left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a real improvement!

I looked into the tile near the pole. The positions I clicked appeared to be close to the expected locations, but I encountered a few bugs. Sometimes the extracted cube is not clickable, and the alignment between the HiPS tile and the extracted cube is not always clear or consistent.

I also see a number of errors like this in the browser console:

Uncaught (in promise) Error: Error from Server for getStretchedByteData: code: 500, text: 
    at fetchExtraction (PlotServicesJson.js:100:15)
    at async updateChart (ExtractionDialog.jsx:577:33)

and a few warnings:

updateStretchDataAfterZoom: unexpected empty rawTileDataGroup

@robyww

robyww commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

I think you are seeing extraction bugs. This PR does not include the new extraction updates. I think I will merge this PR and do more extraction testing when the code is all together.

- a little refactor and some test
@robyww
robyww force-pushed the FIREFLY-2122-more-hips-accuracy branch from e608860 to c025fba Compare October 28, 2026 01:50
@robyww
robyww merged commit 663a50e into dev Oct 28, 2026
2 checks passed
@robyww robyww added this to the 2026.4 milestone Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants