Repository navigation
Firefly-2122: improve HiPS accuracy around poles - #2050
Merged
Merged
Conversation
robyww
force-pushed
the
FIREFLY-2122-more-hips-accuracy
branch
from
October 27, 2026 20:58
a306a37 to
e608860
Compare
tgoldina
approved these changes
Oct 27, 2026
tgoldina
left a comment
Contributor
There was a problem hiding this comment.
This is a real improvement!
I looked into the tile near the pole. The positions I clicked appeared to be close to the expected locations, but I encountered a few bugs. Sometimes the extracted cube is not clickable, and the alignment between the HiPS tile and the extracted cube is not always clear or consistent.
I also see a number of errors like this in the browser console:
Uncaught (in promise) Error: Error from Server for getStretchedByteData: code: 500, text:
at fetchExtraction (PlotServicesJson.js:100:15)
at async updateChart (ExtractionDialog.jsx:577:33)
and a few warnings:
updateStretchDataAfterZoom: unexpected empty rawTileDataGroup
Contributor
Author
|
I think you are seeing extraction bugs. This PR does not include the new extraction updates. I think I will merge this PR and do more extraction testing when the code is all together. |
- a little refactor and some test
robyww
force-pushed
the
FIREFLY-2122-more-hips-accuracy
branch
from
October 28, 2026 01:50
e608860 to
c025fba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2122: improve HiPS accuracy around poles
Note: the wcs match does not work very well when really close to the poles, but the is a future task
Testing