Skip to content

Firefly-453: Fix client-side bug when copying cells from tables - #2052

Merged
aventura121 merged 1 commit into
devfrom
FIREFLY-453-copy-cells-from-tables
Oct 29, 2026
Merged

aventura121 merged 1 commit into
devfrom
FIREFLY-453-copy-cells-from-tables

Conversation

@aventura121

@aventura121 aventura121 commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Firefly-453: copy cells from tables

Description: We fix a CSS-browser interaction related to scrollable containers by changing overflow: hidden to overflow: clip. The bug happens in Firefox when trying to use your cursor to select from one table cell's value to the next.

Build: https://firefly-453-copy-cells-from-tables.irsakubedev.ipac.caltech.edu/firefly

Validation:

  1. Open Firefox and bring up a table, for example by loading the TAP view.
  2. With your mouse and cursor, click and hold one table cell's value and drag the cursor into the adjacent cell's value (for example, pos.eq.ra;meta.main and right ascension (J2000) from the ucd and description columns).
Screenshot of selection working selection
  1. With the fix, we expect that the selection/highlight will work (the adjoining cells are highlighted). (We can compare the error mode in Firefox on irsacloud, for example; the selection wraps back around improperly).

@aventura121 aventura121 added this to the 2026.4 milestone Oct 28, 2026
@aventura121 aventura121 self-assigned this Oct 28, 2026
@aventura121 aventura121 changed the title Firefly 453 copy cells from tables Firefly-453: Fix client-side bug when copying cells from tables Oct 28, 2026
@aventura121
aventura121 marked this pull request as ready for review October 28, 2026 16:50
@lrebull

lrebull commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

oh, wow, it works GREAT. so nice!!!

@jaladh-singhal jaladh-singhal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! What a quirky CSS bug 😄

@aventura121
aventura121 force-pushed the FIREFLY-453-copy-cells-from-tables branch from 147c442 to e9e1659 Compare October 29, 2026 16:34
@aventura121
aventura121 merged commit ad27bdd into dev Oct 29, 2026
2 checks passed
@aventura121
aventura121 deleted the FIREFLY-453-copy-cells-from-tables branch October 29, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants