Repository navigation
fix(desktop-gpui): transcribe only the audio the timeline keeps - #2747
Merged
richiemcilroy merged 6 commits intoOct 26, 2026
Merged
Conversation
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
![superagent-security[bot]](https://avatars.githubusercontent.com/in/3287076?s=60&v=4){kind=small}
Contributor
Author
|
@greptileai review |
# Conflicts: # apps/desktop-gpui/src/transcription.rs
# Conflicts: # crates/project/src/lib.rs
Member
|
@greptileai review |
richiemcilroy
approved these changes
Oct 26, 2026
richiemcilroy
left a comment
richiemcilroy
left a comment
Member
There was a problem hiding this comment.
Verified for 0.6.2: Greptile 5/5 on this head, full CI green, and the full test suites pass on macOS with this PR combined with the other 0.6.2 changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generating captions decoded and transcribed every recording segment in full, ignoring the timeline. so a 30 minute recording trimmed down to 1 minute still sent all 30 minutes through the model, which is slow and was half of what #2719 hit. the long input crash itself was already fixed by #2539.
now it works out the source ranges the timeline actually keeps, merges overlaps, joins just those into one audio buffer and runs the model once, then maps word times back to source time through an offset table so caption placement doesn't change. if an undo brings back audio while it's running, it asks you to generate again instead of applying partial captions. the captions oracles pass.
fixes #2719
The PR appears safe to merge; no new blocking issues were found.Summary
Caption generation now reads only the source audio kept by the timeline.
No new actionable issues were found. The earlier restored-audio finding is addressed.
Reviews (4) · Last reviewed commit: "perf(desktop-gpui): move decoded transcr..." · Reviewed by Greptile