Repository navigation
fix(presets): keep caption text in the editor and CLI - #3311
Merged
Merged
Conversation
Contributor
|
@AksharP5 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Author
|
@greptileai review |
Contributor
Author
|
@greptileai review |
Member
|
@greptileai review |
richiemcilroy
approved these changes
Oct 26, 2026
richiemcilroy
left a comment
Member
There was a problem hiding this comment.
Verified for 0.6.2: Greptile 5/5 on this head, full CI green, and the full test suites pass on macOS with this PR combined with the other 0.6.2 changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applying a preset in the GPUI editor or a CLI upload automation could replace a recording's caption text with another recording's transcript, or clear its saved caption source. CLI automations also discarded the current clip offsets.
Both paths now share the project merge: keep the recording's caption source, timing, timeline, clips and text versions while applying preset styling. Built-in Default uses it too. Newly saved presets contain caption settings without transcript text. CLI application uses defaults for a missing config and surfaces other load errors before writing.
Closes #3310.
Other recordingtoCurrent recordingOther recordingCurrent recording; preset styling appliesVerification on
df1e9e2ae5dbb7f05da3e8f37a879a879fa2f5e3: 13 production GUI preset tests, 3 CLI regressions and 195 shared-project tests pass; four benchmarks are ignored. The original GUI reproductions fail before the fix. Against the original CLI method, caption preservation and unreadable-config protection also fail.An independent GPT-6.1 Sol xhigh review passed the full patch, 25 focused tests including nine additional probes, and the 195 project tests. The old CLI method fails six of those nine probes. Tests cover actual project IO, caption synchronization and save/reopen, legacy timing across cuts, per-caption overrides, text versions, missing configs, and load/write failures.
Formatting, whitespace and scoped strict Clippy pass. Verification uses actual GUI/project sources and verbatim CLI methods with store/context fixtures. Full local workspace/native checks stop at missing pkg-config/OpenSSL dependencies; dependency-inclusive Clippy also encounters existing Rust 1.99 warnings. No native GUI or live upload was run. Greptile reviewed
df1e9e2at 5/5.Native CI on
df1e9e2passed the full GPUI app tests on Apple Silicon macOS, Windows, and Linux: 1,477, 1,436 and 1,552 tests passed respectively, with zero failures and all 13 preset tests included. macOS/Windows Clippy and Linux Rust tests also passed. Those native results coverdf1e9e2.After the maintainer merged upstream
mainin7419e76, the four-file fix has the same stable patch ID as the independently reviewed version. All 13 GUI preset tests, 3 CLI regressions and 196 shared-project tests pass against the merged source, with four benchmarks ignored; formatting and whitespace checks pass. Native CI and Greptile are rerunning for the merge commit.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
The editor and CLI now use
with_presetto apply styling without replacing recording-specific captions or edits.No actionable issues were found. This review checked source paths; it did not run tests or the native UI.
Reviews (4) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." · Reviewed by Greptile