Repository navigation
Conversation
Contributor
|
@Aqua-123 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The incremental writer flushes every 5 seconds during a recording. For the keyboard file, each flush encoded all presses since the start with
KeyboardEvents::to_bytesand kept a second copy of every press. The total work grows with the square of the recording length. #3034 madecursor.jsonappend-only; this does the same forkeyboard.bin.What changed
KeyboardEventsEncoderincap-projectkeeps the encoded presses and encodes only new ones. Each write is the magic header, the varint press count, then the kept bytes. This is the bincode standard layout, so the file is byte-identical toto_bytes().IncrementalFilesuses the encoder and keeps the atomic replace.Scope
Verification
to_bytes(). Reproduce withcargo run -p cap-project --release --example keyboard-incremental-encoding-benchmark -- 7.to_bytes()after each random batch and at varint width boundaries (250/251, 65,535/65,536). Existing incremental writer tests incursor.rspass unchanged.

Confidence Score: 5/5
The PR appears safe to merge; no actionable issues were found.Summary
This PR encodes each new keyboard press once and keeps the encoded bytes for later flushes.
No actionable issues were found. Tests and benchmarks were inspected, not run.
Reviews (1) · Last reviewed commit: "perf(recording): append keyboard presses..." · Reviewed by Greptile