Repository navigation
Conversation
Contributor
|
@Aqua-123 is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
On NVIDIA GPUs, MP4 export keeps the NVENC engine at 100% and the CPU stages wait on it. Export uses preset
p5. On screen recordings,p4gives the same quality and file size and encodes about 1.65× faster.What changed
p5top4.tune=hq, VBR, spatial and temporal AQ andb_ref_mode=middlestay the same. Recording settings are unchanged.Tradeoffs
p1–p3are faster still, but at the same bitrate target they made 20–25% larger files on screen content without a VMAF gain.p4is the fastest preset that keeps file size flat.Blast Radius
Every NVENC export on Windows and Linux, plus render-farm workers that encode with NVENC. Only the encoder speed/quality trade changes. The bitrate, GOP and profile are the same, so players and uploads see the same kind of stream.
Verification
cap export, RTX 3060 (driver 615.78), 5 alternating runs per side, all medians:p4≈p5VMAF (±0.05) at about 60% of the encode time.cargo test -p cap-enc-ffmpeg: 224 passed.

Confidence Score: 5/5
This PR appears safe to merge.Summary
Changes the NVENC export preset from
p5top4.Reviews (1) · Last reviewed commit: "perf(export): encode NVENC exports with ..." · Reviewed by Greptile