Repository navigation
fix(mobile): keep organization settings with the active account - #3465
Open
vedanth-jadhav wants to merge 1 commit into
Open
vedanth-jadhav wants to merge 1 commit into
vedanth-jadhav wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The organization settings screen keeps its draft and pending actions when the active organization changes. A late save can then replace the next organization's form, and a photo selected for the previous organization can be uploaded using the new active organization.
Reset the screen state on account or organization changes, ignore results from the old screen, and stop an old photo-picker or action-sheet flow before it can submit. If the settings response identifies a different organization from the current bootstrap, show an error rather than exposing editable fields.
Validation: 21 focused mobile tests pass (seven organization-settings, six profile-settings, eight existing auth-provider tests). Five new regressions fail against main 97c8d63; two existing controls pass. The new tests cover organization switching with a draft, a pending save, a pending photo picker and an old action sheet, plus a server/bootstrap mismatch. Combined with the pending auth fix in #3356, all 28 settings/auth-provider tests pass. Biome and git diff --check pass. Tests mount the screen with React Test Renderer and controlled native API responses; a native app build and full mobile typecheck were not run.
The mobile API resolves the active organization server-side and does not accept an expected organization ID. This fix protects changes known to the app and mismatched reads; an independent server-side organization switch before the app refreshes remains outside its guarantee. No API or dependency changes.
The PR appears safe to merge; no actionable issues were found.Summary
Keeps organization settings tied to the signed-in account and active organization.
vedanth-jadhavexplicitly notes that an independent server-side organization switch before the app refreshes remains outside this fix's guarantee because the API does not accept an expected organization ID.Review checks were read-only. Tests and a native build were not run.
Reviews (1) · Last reviewed commit: "fix(mobile): keep organization settings ..." · Reviewed by Greptile