Repository navigation
fix(web): release comment capture after browser recorder failures - #3466
Open
vedanth-jadhav wants to merge 1 commit into
Open
vedanth-jadhav wants to merge 1 commit into
vedanth-jadhav wants to merge 1 commit into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a browser encoder errors or stops unexpectedly, the voice and video comment recorders can continue displaying an active recording while retaining microphone or camera capture. An encoder failure during a requested stop is also only logged, leaving no user-facing explanation.
Observe the existing recorder error state, release capture and timers, discard the failed take, and offer a retry. Video comments display an error; voice comments display an explicit interrupted-recording message. Errors during a requested stop also surface instead of producing a partial comment.
Validation: 19 focused tests pass, including voice/video browser error and unexpected-stop cases, errors during a requested stop, the visible voice retry UI and existing recorder setup tests. Four new unexpected-stop cases fail on main 97c8d63; the two stop-in-progress cases fail before their follow-up fix. Tests use mounted React hooks and controlled MediaRecorder events; physical capture devices were not tested. Scoped strict TypeScript for both hooks and their lifecycle tests, Biome, CI YAML parsing and git diff --check pass; full web build/typecheck was not run.
Combined with #3464, 27 hook/setup tests pass. Both PRs touch the voice recorder and require the stop-handler hunks to be combined if either merges first. #3464 handles take ownership and synchronous start failures; this PR handles asynchronous browser recorder errors.
The PR appears safe to merge; no actionable issues were found.Summary
Releases voice and video comment capture after unexpected browser recorder stops and gives users a retry path.
No actionable issues found. Tests and physical capture were not run during this review.
Reviews (1) · Last reviewed commit: "fix(web): release comment capture after ..." · Reviewed by Greptile