Repository navigation
fix(web): accept semicolon separated Loom CSVs - #3518
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Member
Author
|
@greptileai review |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Spreadsheet apps set to many European locales save CSV files with semicolons between columns instead of commas.
parseLoomCsvRecordsonly split on commas, so a file likewas read as a single column called
loom_video_url;user_email. The Loom CSV import page then could not map a video URL column and the Review Import button stayed disabled with no explanation.Fix
parseLoomCsvRecordsnow picks the delimiter from the header line before parsing: it counts unquoted commas and semicolons on the first line that has content (blank lines and lines of empty cells before the header are skipped) and uses a semicolon only when there are more of those than commas. Everything else in the parser is unchanged.Both callers (the CSV import page and the admin concierge upload) go through this function, so both get the fix.
Testing
loom-csv.test.tsfor semicolon files, quoted commas in a semicolon file, comma files with semicolons in values, a single column file, and a semicolon file with blank lines before the header. The semicolon tests fail onmainand pass with the change. All 18 tests in the file pass.biome checkis clean on both files.

Confidence Score: 5/5
The PR appears safe to merge; both previous findings are addressed.Summary
Adds semicolon-separated Loom CSV support in the shared parser.
Reviews (2) · Last reviewed commit: "fix(web): skip blank lines when detectin..." · Reviewed by Greptile