Skip to content

feat(desktop-gpui): glass library and target tiles, native device and format lists - #3519

Merged
richiemcilroy merged 2 commits into
mainfrom
feat/gpui-library-device-polish
Oct 28, 2026
Merged

richiemcilroy merged 2 commits into
mainfrom
feat/gpui-library-device-polish

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Brings the main window's lists in line with its glass capture tiles.

Recordings and screenshots

  • Each tile is a glass panel with the capture tiles' fill and hairline. The preview is inset in it with its own rim; a recording without a thumbnail shows a soft gradient with the mode icon.
  • Every action (edit, open link, retry upload, open folder, delete, copy, save as) has a tooltip and an accessible label, reusing the existing Settings strings, so every language already has them.
  • The View All tile matches, with an arrow chip.

Display and window cards

  • The same glass card and inset preview; the chosen card keeps its blue tint and edge.

Camera and microphone

  • One grouped list, the way macOS lays out a choice: flat rows, hairlines that start at the text, a check on the chosen device.
  • The chosen device's detail line shows its available format until the applied one arrives, so the row no longer grows a moment after the list opens (the jump in the microphone list).

Format preferences

  • A header with the device and its current format, then the formats in the same grouped list: size or sample rate, with the frame rate or channels muted on the right.
  • Placeholder rows the height of real ones while the formats load, so the list does not jump; errors and "Applying" show as a caption under the list.

CAP_GPUI_AUTO_PANEL also takes recordings and screenshots, for screenshots of these panels.

Test plan

  • cargo test for the main window, target thumbnails and library (91 pass), no new warnings
  • Screenshots on the Mac mini in light and dark, before and after, with sample recordings and screenshots: recordings, screenshots, display cards, camera and microphone lists; the recordings panel still scrolls
  • Tried by hand in a local build on macOS

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; the previous comment finding is fixed and no new blocking issues were found.

Summary

Updates the desktop’s library tiles, target cards, and device lists.

  • Recording and screenshot tiles now use the capture window's glass look.
  • Display and window cards now use glass panels around their previews.
  • Camera and microphone choices now sit in grouped glass lists.
  • Device format choices now show their details in a grouped list.

No new actionable issues were found.

Reviews (2) · Last reviewed commit: "fix(desktop-gpui): show Loading formats ..." · Reviewed by Greptile

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cap-status Ready Ready Preview Oct 28, 2026 3:05pm UTC

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

View 2 other findings in Capy.

Open in Capy

Comment thread apps/desktop-gpui/src/main_window.rs Outdated
Comment on lines +213 to +214
/// A grouped list, the way macOS lays out a choice: one panel, rows split by
/// hairlines that start `inset` in, where the text does.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Comments repeat the code

The new comments above grouped_list, library_tile, and DeviceFormat::parts describe their layout or output. AGENTS.md explicitly bans comments that narrate what the code does. Remove these descriptive comments before merging; keep comments that explain a real timing issue or trade-off.

Context Used: AGENTS.md (source)

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop-gpui/src/main_window.rs
Line: 213-214

Comment:
**Comments repeat the code**

The new comments above `grouped_list`, `library_tile`, and `DeviceFormat::parts` describe their layout or output. `AGENTS.md` explicitly bans comments that narrate what the code does. Remove these descriptive comments before merging; keep comments that explain a real timing issue or trade-off.

**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@richiemcilroy

Copy link
Copy Markdown
Member Author

@greptileai the layout-describing comments are gone in 0e3d27b; please re-review.

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

@richiemcilroy
richiemcilroy merged commit c0be8a9 into main Oct 28, 2026
61 checks passed

This branch was successfully deployed

2 active deployments
Preview – cap-web — 0e3d27ba Deployed Oct 28, 2026 by vercel[bot]
Preview – cap-status — 0e3d27ba Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant