Repository navigation
feat(desktop-gpui): glass library and target tiles, native device and format lists - #3519
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Comment on lines
+213
to
+214
| /// A grouped list, the way macOS lays out a choice: one panel, rows split by | ||
| /// hairlines that start `inset` in, where the text does. |
Contributor
There was a problem hiding this comment.
The new comments above grouped_list, library_tile, and DeviceFormat::parts describe their layout or output. AGENTS.md explicitly bans comments that narrate what the code does. Remove these descriptive comments before merging; keep comments that explain a real timing issue or trade-off.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/desktop-gpui/src/main_window.rs
Line: 213-214
Comment:
**Comments repeat the code**
The new comments above `grouped_list`, `library_tile`, and `DeviceFormat::parts` describe their layout or output. `AGENTS.md` explicitly bans comments that narrate what the code does. Remove these descriptive comments before merging; keep comments that explain a real timing issue or trade-off.
**Context Used:** AGENTS.md ([source](https://github.com/capsoftware/cap/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
…ly the comments that explain why
Member
Author
|
@greptileai the layout-describing comments are gone in 0e3d27b; please re-review. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the main window's lists in line with its glass capture tiles.
Recordings and screenshots
Display and window cards
Camera and microphone
Format preferences
CAP_GPUI_AUTO_PANELalso takesrecordingsandscreenshots, for screenshots of these panels.Test plan
cargo testfor the main window, target thumbnails and library (91 pass), no new warnings

Confidence Score: 5/5
The PR appears safe to merge; the previous comment finding is fixed and no new blocking issues were found.Summary
Updates the desktop’s library tiles, target cards, and device lists.
No new actionable issues were found.
Reviews (2) · Last reviewed commit: "fix(desktop-gpui): show Loading formats ..." · Reviewed by Greptile