Repository navigation
Conversation
setup-beam treats any version-type other than 'strict' as loose, so the 'stict' typo meant .tool-versions versions were matched loosely despite the README's promise of strict matching. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About This Change
Description
Warning
Do not publish a release of this until the five library issues below are closed. Publishing a release moves
@v1, and the libraries pinerlang 28, which strict matching cannot resolve. Merging is harmless; the release is the breaking step.setup-beamtreats anyversion-typeother than'strict'as loose, so the'stict'typo inaction.ymlmeant versions read from.tool-versionswere matched loosely, despite the README saying they are matched strictly. This fixes the typo, so the action behaves as documented.Code Review Triage
My confidence in this change:
Which parts: The code change is one character. The risk is the release, covered above. This action's own CI passes versions explicitly, so it does not exercise the
.tool-versionspath.Test coverage:
If we miss an issue here, the primary blast radius is:
If we change our minds about this approach later, reversing it would mean:
Time constraints (leave blank if none):
Who was involved in planning/design/development so far?
What signal would tell us this code is safe to remove — a flag retired, a feature sunset, a migration completed?
Type of Change
Changes
action.yml:'stict'→'strict'in theversion-typepassed toerlef/setup-beamwhen either version comes from.tool-versions.Link Backs
Testing & Validation
erlef/setup-beamv1.24.1: it checksversion-type === 'strict'and treats every other value as loose, which is why the typo never errored..tool-versionsagainst https://builds.hex.pm/builds/otp/ubuntu-24.04/builds.txt:erlang 28; there is no plainOTP-28build). Each has an issue to pin an exact version and test it.27.3.4.17and Elixir versions).CargoSense/setup-elixir-project@pragdave-fix-strict-version-type.Development Process
As You Begin
We like PRs, and you are encouraged to open a PR when you start a branch, keep it as a draft (https://bit.ly/github-draft), and document your progress as you work on the code.
Before You Deploy
Public Changes
@CargoSense/product)Follow-Up Work
@v1) once the five library issues are closed.NOTE: MERGING TO MAIN DEPLOYS TO PRODUCTION
🤖 Generated with Claude Code