Skip to content

[ENG-10627] avoid Preprint Title Incorrectly Hyperlinked #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brianjgeiger merged 1 commit into from
Oct 20, 2026
Merged

[ENG-10627] avoid Preprint Title Incorrectly Hyperlinked #1082

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 14 additions & 11 deletions src/app/features/preprints/pages/preprint-details/preprint-details.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,21 @@
<p-skeleton width="12rem" height="2.25rem" />
</div>
} @else {
<a
class="flex flex-column gap-3 custom-light-hover dark-blue-link md:flex-row"
[routerLink]="['/preprints', preprintProvider()?.id, 'discover']"
>
<img
class="fit-contain"
height="36"
[src]="preprintProvider()?.brand?.heroLogoImageUrl"
[alt]="'preprints.selectService.providerLogoImageAlt' | translate"
/>
<div class="flex flex-column gap-3 md:flex-row">
<a
class="flex align-self-start max-w-full custom-light-hover"
[routerLink]="['/preprints', preprintProvider()?.id, 'discover']"
>
<img
class="fit-contain max-w-full"
height="36"
[src]="preprintProvider()?.brand?.heroLogoImageUrl"
[alt]="'preprints.selectService.providerLogoImageAlt' | translate"
/>
</a>

<h1>{{ preprint()?.title }}</h1>
</a>
</div>
}

@if (moderationMode()) {
Expand Down
11 changes: 11 additions & 0 deletions src/app/features/preprints/pages/preprint-details/preprint-details.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,17 @@ describe('PreprintDetailsComponent', () => {
expect(component.isOsfPreprint()).toBe(true);
});

it('should render the title outside of the provider logo link', () => {
setup();

const title: HTMLElement = fixture.nativeElement.querySelector('h1');
const logoImage: HTMLElement = fixture.nativeElement.querySelector('img.fit-contain');

expect(title.textContent?.trim()).toBe(mockPreprint.title);
expect(title.closest('a')).toBeNull();
expect(logoImage.closest('a')).not.toBeNull();
});

it('should mark preprint withdrawable for pending and accepted states', () => {
setup();
vi.spyOn(component, 'preprint').mockReturnValue({ ...mockPreprint, reviewsState: ReviewsState.Pending } as any);
Expand Down
Loading