Repository navigation
test: build Hood ErrTrace image - #40
Closed
littlehand26 wants to merge 6 commits into
Closed
littlehand26 wants to merge 6 commits into
littlehand26 wants to merge 6 commits into
Conversation
InitializeArbosInDatabase force-disabled trie preimages. This is a long-standing default (the pre-pathdb code also hardcoded Preimages:false): genesis is a one-time bulk state import and preimages are unused for normal node operation, so they were skipped. On the path state scheme this breaks the pipeline's OnArbGenesisBlock state dump. Without preimages the dump cannot reverse-resolve account addresses (tr.GetKey returns nil), so it opens each storage trie with a zero address, derives the wrong pathdb owner (Keccak256(0x00..00)), fails the lookup, and drops every storage-bearing genesis account (EntryPoint code + slots, the ArbOS 0xA4B05 system state, etc.). The hash scheme is unaffected because its reader resolves nodes by hash and ignores the owner. Honor cacheConfig.Preimages (driven by --execution.caching.enable-preimages) instead of forcing it off. Default behavior is unchanged: EnablePreimages and both Defaults/ArchiveDefaults default to false, so genesis init records no preimages unless explicitly enabled. Preimages live in a separate rawdb table and are not part of the state root, so there is no consensus impact.
Contributor
Author
|
Closing this test-only image-build PR. Snapshot validation evidence is retained; this PR must not be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only PR for the Hood snapshot-validation image. Its head is the exact reviewed Nitro #39 commit (
8b05ce923), including the production genesis-preimages hotfix from #36 and the minimal ErrTrace dependency chain from Pipeline #156 / go-ethereum-arb #29.Do not merge.