Skip to content

refactor: corrige violações de arquitetura (PopcornGP) - #99

Merged
gabrielbmoro merged 3 commits into
masterfrom
gmoro/solve-arc-violations
Oct 28, 2026
Merged

gabrielbmoro merged 3 commits into
masterfrom
gmoro/solve-arc-violations

Conversation

@gabrielbmoro

@gabrielbmoro gabrielbmoro commented Aug 3, 2026 •

Copy link
Copy Markdown
Collaborator

Descrição

Correção de violações de arquitetura detectadas pelo PopcornGP:

  • Extrai interfaces DetailStreamRepository e ProfilePickerStreamRepository para a camada domain
  • Move SearchMapper de domain para presentation
  • Atualiza popcorngp-config.json para refletir as novas regras

Módulos afetados

  • feature-detail
  • feature-profile
  • feature-search
  • build-logic / config
  • gradle / libs.versions.toml

Testes Realizados

  • Build local passa
  • Detekt / PopcornGP sem novas violações

Checklist

  • Os testes foram executados e passaram com sucesso.
  • As alterações de código seguem as diretrizes de estilo do projeto.
  • Foram adicionados testes, se aplicável.
  • Se inscreveu no canal?😛

@gabrielbmoro
gabrielbmoro requested a review from a team as a code owner August 3, 2026 20:25
Comment thread config/detekt/popcorngp-config.json Resolved
Comment thread config/detekt/popcorngp-config.json Resolved
Comment thread config/detekt/popcorngp-config.json Resolved
Comment thread gradle/libs.versions.toml Resolved
import com.codandotv.streamplayerapp.feature.profile.domain.ProfileStream
import com.codandotv.streamplayerapp.feature.profile.domain.toProfiles
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.flowOf
import kotlinx.coroutines.flow.map
import org.koin.core.annotation.Factory

interface ProfilePickerStreamRepository {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assim eu entendo

Q na literatura seria isso mesmo

E soh deixando comentário

Q acho meio opcional pq se vc vai navegar acho pior dessa forma

E o fato do koltin poderia ser um filé com tudo dentro acho q faz mais sentido na prática na navegação

@gabrielbmoro
gabrielbmoro merged commit 4031783 into master Oct 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants