Repository navigation
refactor(tui): demo shared DialogHeader architecture (upstream #55501) - #2
Open
ivanmilevtues wants to merge 2 commits into
Open
ivanmilevtues wants to merge 2 commits into
ivanmilevtues wants to merge 2 commits into
Conversation
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 72 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeBoarding reviewStatus: 2 changed components See the full change in CodeBoarding. graph LR
n_Client_Applications_and_Frontend_UI["Client Applications and Frontend UI"]
n_Core_Engine_and_Runtime["Core Engine and Runtime"]
n_Terminal_User_Interface_TUI_["Terminal User Interface #40;TUI#41;"]
n_AI_Provider_Integration["AI Provider Integration"]
n_CLI_and_Development_Commands["CLI and Development Commands"]
n_Server_and_Plugin_SDK["Server and Plugin SDK"]
n_Shared_Schemas_and_Types["Shared Schemas and Types"]
n_API_Protocol_and_Client_Contracts["API Protocol and Client Contracts"]
n_Infrastructure_and_Documentation_Services["Infrastructure and Documentation Services"]
n_Web_Sharing_Service["Web Sharing Service"]
n_Simulation_and_Mock_Services["Simulation and Mock Services"]
n_LaTeX_Engine["LaTeX Engine"]
n_Theme_and_Color_Specifications["Theme and Color Specifications"]
n_Functions_and_Testing_Utilities["Functions and Testing Utilities"]
n_Client_Applications_and_Frontend_UI -- "invokes utilities from" --> n_Core_Engine_and_Runtime
n_Client_Applications_and_Frontend_UI -- "uses types from" --> n_Shared_Schemas_and_Types
n_Client_Applications_and_Frontend_UI -- "configures proxy via" --> n_Server_and_Plugin_SDK
n_CLI_and_Development_Commands -- "renders via TUI components from" --> n_Terminal_User_Interface_TUI_
n_API_Protocol_and_Client_Contracts -- "binds schemas from" --> n_Shared_Schemas_and_Types
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_Terminal_User_Interface_TUI_ modified;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CodeBoarding demo — leave open
Faithful port of merged upstream anomalyco#55501 by James Long (@jlongster). Includes its six-line prerequisite anomalyco#55498, also by James Long, to reproduce the full stacked PR diff. This is demo material, not new original work or a request to merge.
Why this demo
One shared
DialogHeaderreplaces hand-built header rows across 20 consumers. This shows component consolidation and dependency fan-in in CodeBoarding's architecture diff: 21 source files, +137/−229, no dependency or lockfile churn.Provenance and baseline
Original authors and upstream commit references are preserved using
git cherry-pick -x. Rebased onto synceddevat 74afdf9 without source modifications. Upstream/replayed patch IDs match.Before opening this PR, verified successful licensed baseline sync: https://github.com/CodeBoarding/opencode2/actions/runs/38772657614. It committed
codeboarding/baselineand published the matching base artifact.Checks
bun run checkpasses: lint has warnings but no errors; 36/36 typecheck tasks pass.git diff --checkpasses; rebase leaves source tree unchanged.