Skip to content

refactor(tui): demo shared DialogHeader architecture (upstream #55501) - #2

Open
ivanmilevtues wants to merge 2 commits into
devfrom
demo-dialog-header
Open

ivanmilevtues wants to merge 2 commits into
devfrom
demo-dialog-header

Conversation

@ivanmilevtues

Copy link
Copy Markdown
Member

CodeBoarding demo — leave open

Faithful port of merged upstream anomalyco#55501 by James Long (@jlongster). Includes its six-line prerequisite anomalyco#55498, also by James Long, to reproduce the full stacked PR diff. This is demo material, not new original work or a request to merge.

Why this demo

One shared DialogHeader replaces hand-built header rows across 20 consumers. This shows component consolidation and dependency fan-in in CodeBoarding's architecture diff: 21 source files, +137/−229, no dependency or lockfile churn.

Provenance and baseline

Original authors and upstream commit references are preserved using git cherry-pick -x. Rebased onto synced dev at 74afdf9 without source modifications. Upstream/replayed patch IDs match.

Before opening this PR, verified successful licensed baseline sync: https://github.com/CodeBoarding/opencode2/actions/runs/38772657614. It committed codeboarding/baseline and published the matching base artifact.

Checks

  • bun run check passes: lint has warnings but no errors; 36/36 typecheck tasks pass.
  • git diff --check passes; rebase leaves source tree unchanged.
  • Upstream documents its dialog screenshot/interaction tests. No new local TUI visual verification is claimed.

jlongster and others added 2 commits October 15, 2026 17:56
(cherry picked from commit 4f31eb9)
Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
(cherry picked from commit af6ec83)
Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
@github-actions

Copy link
Copy Markdown

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 72 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-15T17:59:03.984151Z 38b66fa PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

CodeBoarding review

Status: 2 changed components

See the full change in CodeBoarding.

graph LR
    n_Client_Applications_and_Frontend_UI["Client Applications and Frontend UI"]
    n_Core_Engine_and_Runtime["Core Engine and Runtime"]
    n_Terminal_User_Interface_TUI_["Terminal User Interface #40;TUI#41;"]
    n_AI_Provider_Integration["AI Provider Integration"]
    n_CLI_and_Development_Commands["CLI and Development Commands"]
    n_Server_and_Plugin_SDK["Server and Plugin SDK"]
    n_Shared_Schemas_and_Types["Shared Schemas and Types"]
    n_API_Protocol_and_Client_Contracts["API Protocol and Client Contracts"]
    n_Infrastructure_and_Documentation_Services["Infrastructure and Documentation Services"]
    n_Web_Sharing_Service["Web Sharing Service"]
    n_Simulation_and_Mock_Services["Simulation and Mock Services"]
    n_LaTeX_Engine["LaTeX Engine"]
    n_Theme_and_Color_Specifications["Theme and Color Specifications"]
    n_Functions_and_Testing_Utilities["Functions and Testing Utilities"]
    n_Client_Applications_and_Frontend_UI -- "invokes utilities from" --> n_Core_Engine_and_Runtime
    n_Client_Applications_and_Frontend_UI -- "uses types from" --> n_Shared_Schemas_and_Types
    n_Client_Applications_and_Frontend_UI -- "configures proxy via" --> n_Server_and_Plugin_SDK
    n_CLI_and_Development_Commands -- "renders via TUI components from" --> n_Terminal_User_Interface_TUI_
    n_API_Protocol_and_Client_Contracts -- "binds schemas from" --> n_Shared_Schemas_and_Types
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
    class n_Terminal_User_Interface_TUI_ modified;
Loading

download artifacts · run 38781556977

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants