Repository navigation
Upgrade to .NET 10, runner images to windows-2025, use only 26100 Windows SDK - #805
Conversation
|
Found the background info and original source of the bug for the disk space issue here. The mistake was made on Oct 2nd 2025 under https://github.com/CommunityToolkit/Windows/pull/737/files. Per the comments from @michael-hawker in the PR/Issue on this, we intended to keep the "large" runner wherever it was used, but the change here doesn't reflect that. It looks like the bad change has persisted unnoticed since then. The fix here is now certain and should be simple, I'll push that up in a moment. |
|
Closing and re-opening to hopefully rekick CI |
|
Status update on where we are now: Wasdk is passing now, but UWP is still having this same issue: PS V:\Labs-Windows> gh run view 26116949465 --log-failed --job 76808805796 | select-string -pattern "error.+?:" | select -last 2
build (2, uwp) UNKNOWN STEP 2026-05-19T19:08:37.9362118Z EXEC : error : Could not read the Windows SDK's
Platform.xml at C:\Program Files (x86)\Windows Kits\10\Platforms\UAP\10.0.17763.0\Platform.xml [C:\a\Labs-Windows\Labs-
Windows\components\DependencyPropertyGenerator\src\CommunityToolkit.WinUI.DependencyPropertyGenerator.csproj::TargetFra
mework=net8.0-windows10.0.17763.0]
build (2, uwp) UNKNOWN STEP 2026-05-19T19:08:37.9364277Z
C:\Users\runneradmin\.nuget\packages\microsoft.windows.cswinrt\2.2.0\build\Microsoft.Windows.CsWinRT.targets(293,5):
error MSB3073: The command ""C:\Users\runneradmin\.nuget\packages\microsoft.windows.cswinrt\2.2.0\cswinrt.exe" @"C:\a\L
abs-Windows\Labs-Windows\components\DependencyPropertyGenerator\src\obj\x64\Release\net8.0-windows10.0.17763.0\Generate
d Files\CsWinRT\cswinrt.rsp"" exited with code 1. [C:\a\Labs-Windows\Labs-Windows\components\DependencyPropertyGenerato
r\src\CommunityToolkit.WinUI.DependencyPropertyGenerator.csproj::TargetFramework=net8.0-windows10.0.17763.0]That's a discrepancy from the behavior I was getting on my local machine. I was able to build with at minimum the 19041 and 26100 SDKs installed, I haven't been able to reproduce this exact error locally on UWP yet. |
…lable" This reverts commit 2da2c9c.
Pin tooling to CommunityToolkit/Tooling-Windows-Submodule#315 for end-to-end validation before merging the upstream PR. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
cfe6bc1 to
9be869a
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 61f93df2-65f8-429a-8440-6298c871fe79
Set CsWinRTWindowsMetadata=sdk for AppServices, Notifications, and DependencyPropertyGenerator without changing their Windows 17763 targets or minimum OS version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Remove the NuGet.Build.Tasks.Pack 6.12.1 override. It misreads the version-4 assets produced by NuGet 7 and loses implicit platform versions, causing NU1012 during WinUI 3 multi-target packaging. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
a7b7cb7 to
285e8e7
Compare
4389d23 to
5a620b5
Compare
Enable LongPathsEnabled before checkout and build tools start in the Windows build and packaging jobs. Keep the source generator project unchanged instead of overriding its generated editorconfig filename. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
5a620b5 to
7c39ccc
Compare
Avoid the x86 .NET Framework long-path regression tracked in dotnet/msbuild#15333. LongPathsEnabled alone is insufficient because affected x86 hosts initialize legacy CLR path handling; the x64 host already explicitly disables those compatibility switches. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Background
PR #803 intended to fully upgrade us to the
windows-2025runners and has been reviewed by a frequent contributor, closed and merged intomain.Problem
This was surfaced by @Avid29 in the #community-toolkit - Targeting .NET 10 thread on Discord after bringing in the #803 work to unblock #791.
The broken CI problem only appears on #791 and not on
mainbecause surfacing it requires bumping our minimum msbuild version to at least 18.0 and it requires bumping the runner (v17.0 is not included onwindows-2025).Some small but obvious edits were missed and required a follow up PR to fix.
Solution
Corrections have been made. Small PR.