Skip to content

Start and log error (rather than refusing to start) if error while loading settings from -settings flag - #3968

Open
LordIdra wants to merge 1 commit into
ControlSystemStudio:masterfrom
LordIdra:nonexistent-settings-tweak
Open

LordIdra wants to merge 1 commit into
ControlSystemStudio:masterfrom
LordIdra:nonexistent-settings-tweak

Conversation

@LordIdra

@LordIdra LordIdra commented Oct 19, 2026 •

Copy link
Copy Markdown

See #3960

Please let me know if this should be implemented differently e.g. only if the file does not exist rather than for any error

Checklist

  • Testing:

    • The feature has automated tests
    • Tests were run
    • Tested manually that application starts as normal and logs an error when -settings file does not exist, and that the settings are loaded if the -settings file does exist
  • Documentation:

    • The feature is documented
    • The documentation is up to date (could not find any docs to update)
    • Release notes:
      • Added an entry if the change is breaking or significant
      • Added an entry when adding a new feature

@LordIdra LordIdra changed the title Start and log error (rather than refusing to start) if -settings flag points to nonexistent file Start and log error (rather than refusing to start) if error while loading settings from -settings flag Oct 19, 2026
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Security Rating on New Code (required ≥ A)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

PropertyPreferenceLoader.load(location);
} catch (Exception e) {
logger.severe("Failed to load settings from " + location);
e.printStackTrace();

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants