Repository navigation
Conversation
This reverts commit b91ebd4. Fix needed JFX 25, which Phoebus is now running with.
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to reapply the previous reverted fix for the scrollbar flickering in the Phoebus display.
The initial fix was merged here: #3887 but this broke the styling of other widgets under JFX21 - see reported issue #3891 and the bug in JFX21 that caused this: https://bugs.openjdk.org/browse/JDK-8336097)/.
This commit was then reverted #3893 until we moved to JFX25 (as the underlying bug was fixed in JFX24).
Phoebus is now building against JFX25, which means that we can reapply the fix for the scrollbar flickering without breaking the styling for other widgets.
Checklist
Testing:
Documentation: